Merged
Conversation
vyasworks
reviewed
Mar 16, 2023
vyasworks
reviewed
Mar 16, 2023
vyasworks
reviewed
Mar 16, 2023
Contributor
vyasworks
left a comment
vyasworks
left a comment
There was a problem hiding this comment.
few suggestions but rest is good
vyasworks
previously approved these changes
Mar 17, 2023
chelsea-EYDS
force-pushed
the
report_two
branch
from
11461d9 to
2b857f8
Compare
[CCFPCM-378] updated as per teams channel feedback [CCFPCM-378] rebased [CCFPCM-379] second report
chelsea-EYDS
force-pushed
the
report_two
branch
from
f01fff3 to
bd96247
Compare
Contributor
Author
|
Sorry, it's a long one. Lots of changes required in order to make the function params semantically correct for the reporting service (vs being specific to the reconciliation services). |
chelsea-EYDS
force-pushed
the
report_two
branch
from
3b09864 to
c70c695
Compare
chelsea-EYDS
force-pushed
the
report_two
branch
from
c70c695 to
84285b1
Compare
vyasworks
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCFPCM-0379
Objective:
Add in second worksheet for the report
Include more logging
Update the services for querying to use more generic params
TODO: add filtering (will follow up with this in a separate PR)