Merged
Conversation
… and ease of unit testing
fw-noel
reviewed
May 8, 2023
| appLogger: Logger, | ||
| cashRecon: CashReconciliationService | ||
| cashRecon: CashReconciliationService, | ||
| exceptionsService: CashExceptionsService |
Collaborator
There was a problem hiding this comment.
Argument for renaming to cashExceptionsService for consistency?
| ); | ||
| this.appLogger.log( | ||
| `${aggregatedPayments.length} AGGREGATED PAYMENTS PENDING RECONCILIATION`, | ||
| `${aggregatedPayments?.length} AGGREGATED PAYMENTS PENDING RECONCILIATION`, |
Collaborator
There was a problem hiding this comment.
If this nullish is necessary, then I imagine you'd want aggregatedPayments?.length || 0. Otherwise, the log won't look right!
Contributor
Author
There was a problem hiding this comment.
Oops, good call! On this topic, I was wondering if I should scale back the logs? Or maybe add more logging to the specific services that I are querying for/updating the data vs having the logs here? The logs are bit unwieldily...
Collaborator
There was a problem hiding this comment.
Logs are cheap, no need to scale back, but we may want to refine them so as to make them easier to sift through.
fw-noel
previously approved these changes
May 10, 2023
fw-noel
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHORE
Objective: