#1702 - Allow institution to specify custom regulatory body #1763
Conversation
Worked on displaying other regulating institution in the Institution Profile
…y_custom_regulatory_body' into 1702_allow_institution_to_specify_custom_regulatory_body
Removed my changes related to prettier from .eslintrc.js which I mistakenly committed previously
sh16011993
added
Content
sh16011993
requested review from
andrepestana-aot,
andrewsignori-aot,
ann-aot and
dheepak-aot
...es/packages/backend/apps/db-migrations/src/sql/Institution/Add-col-other-regulating-body.sql
Outdated
Show resolved
Hide resolved
sources/packages/backend/libs/sims-db/src/entities/institution.model.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/route-controllers/institution/models/institution.dto.ts
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/services/institution/institution.service.model.ts
Outdated
Show resolved
Hide resolved
| -- Add other_regulating_body column to institutions table | ||
| ALTER TABLE sims.institutions ADD COLUMN IF NOT EXISTS other_regulating_body VARCHAR(100); | ||
|
|
||
| COMMENT ON COLUMN sims.institutions.other_regulating_body IS 'Allows the user to enter the description if the option other is selected from the regulating body dropdown'; No newline at end of file |
There was a problem hiding this comment.
Please add a period at the end of the sentence.
There was a problem hiding this comment.
Thanks. Will do.
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice and great first PR. @ann-aot and @dheepak-aot covered pretty much everything. I will be waiting for the changes to review again.
There was a problem hiding this comment.
Great job @sh16011993 . The other devs already addressed the issues. One thing I noticed: please let the person who commented to resolve the conversation.
Actually I was talking to @ann-aot at the time I resolved the specific conversation with her. We discussed on the call and then resolved it. |
@andrewsignori-aot I have updated the code with the review comments. |
| @IsNotEmpty() | ||
| regulatingBody: string; | ||
| @ValidateIf((e) => e.regulatingBody === "other") | ||
| @IsNotEmpty() |
There was a problem hiding this comment.
Same max length validation needs to added here as well.
There was a problem hiding this comment.
I apologize, I missed it.
| regulatingBody: string; | ||
|
|
||
| /** | ||
| * Other regulating body |
There was a problem hiding this comment.
Period missing in the comment. Also please try to use the same comment used for the column.
|
Thanks for doing the changes. Added 2 more comments. |
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for doing the changes @sh16011993. Nice beginning.
sources/packages/forms/src/form-definitions/institutionprofilecreation.json
Outdated
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/institutionprofile.json
Outdated
Show resolved
Hide resolved
sources/packages/backend/apps/api/src/route-controllers/institution/models/institution.dto.ts
Show resolved
Hide resolved
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Thanks for doing the changes. Please take a look on the last minor comments.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Thanks for doing the changes, it looks good 👍
ann-aot
left a comment
ann-aot
left a comment
There was a problem hiding this comment.
Good start and good work @sh16011993 👍 Thanks for doing the changes
sh16011993
deleted the
1702_allow_institution_to_specify_custom_regulatory_body
branch
institutionprofilecreation.jsonform to add Other as a value to the Institution regulating body dropdown and the Other Regulating Body text field.other_regulating_bodycolumn to the database and created the appropriate database migration scripts along with the required SQL script to add theother_regulating_bodycolumn and also the SQL script to remove the column if the migration needs to be reverted.institutionprofile.jsonform to display Other regulating body field in the Institution profile on the AEST portal.Updating the field:
After the update:
