#1959 - Staging sims prod environment : formio GitHub action build deploy split #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
requested review from
JasonCTang,
andrepestana-aot,
andrewsignori-aot,
ann-aot,
dheepak-aot and
sh16011993
Collaborator
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice work, minor comments only.
sh16011993
requested changes
Jun 8, 2023
Collaborator
sh16011993
left a comment
sh16011993
left a comment
There was a problem hiding this comment.
Nice work 👍 . Please have a look at @andrewsignori-aot comments.
|
Kudos, SonarCloud Quality Gate passed!
|
dheepak-aot
approved these changes
Jun 8, 2023
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
approved these changes
Jun 8, 2023
guru-aot
deleted the
feature/#1959-Staging-SIMS-Prod-Environment-Formio-GithubAction-Build-Deploy
branch
ann-aot
reviewed
Jun 8, 2023
| gitRef: | ||
| description: "Git Ref" | ||
| required: true | ||
| default: "" |
Contributor
There was a problem hiding this comment.
why should we need the default as empty?
Contributor
Author
There was a problem hiding this comment.
The git ref for build is the reference something like main-65, it does not have any default value.
ann-aot
reviewed
Jun 8, 2023
| run: | | ||
| echo BUILD NAMESPACE: $BUILD_NAMESPACE | ||
| echo BRANCH: $BUILD_REF | ||
| # Checkout the PR branch |
Contributor
There was a problem hiding this comment.
line 39 too and comments in other files too.
Contributor
Author
There was a problem hiding this comment.
Will update it in my next pr
andrewsignori-aot
pushed a commit
that referenced
this pull request
Jun 8, 2023
…ploy split (#2000) Split the github action workflow which currently builds and deploys simultaneously in a single action into seperate build and deploy github action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the github action workflow which currently builds and deploys simultaneously in a single action into seperate build and deploy github action.