Skip to content

#2086 - Fix question repetition #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dheepak-aot merged 1 commit into from
Jul 7, 2023
Merged

#2086 - Fix question repetition #2090

dheepak-aot merged 1 commit into from
Jul 7, 2023

Conversation

@dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jul 7, 2023

Issue

The regulatory body question was repeating
image

After fix

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dheepak-aot dheepak-aot self-assigned this Jul 7, 2023
@dheepak-aot dheepak-aot added the Form.io Form IO definitions changed. label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.89% ( 2127 / 11892 )
Methods: 8.31% ( 126 / 1516 )
Lines: 20.68% ( 1863 / 9009 )
Branches: 10.1% ( 138 / 1367 )

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 71% ( 399 / 562 )
Methods: 61.97% ( 44 / 71 )
Lines: 72.97% ( 351 / 481 )
Branches: 40% ( 4 / 10 )

andrewsignori-aot
andrewsignori-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ann-aot
ann-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 50.18% ( 3543 / 7061 )
Methods: 45.63% ( 418 / 916 )
Lines: 55.38% ( 2915 / 5264 )
Branches: 23.84% ( 210 / 881 )

guru-aot
guru-aot approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@guru-aot guru-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dheepak-aot dheepak-aot merged commit f4c6f36 into main Jul 7, 2023
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:42 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:45 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:46 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot temporarily deployed to DEV July 7, 2023 20:46 — with GitHub Actions Inactive
@dheepak-aot dheepak-aot deleted the fix/#2085-question-repetition branch July 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

@JasonCTang JasonCTang Awaiting requested review from JasonCTang

+2 more reviewers

@guru-aot guru-aot guru-aot approved these changes

@ann-aot ann-aot ann-aot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dheepak-aot dheepak-aot

Labels

Form.io Form IO definitions changed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dheepak-aot @andrewsignori-aot @guru-aot @ann-aot