#4652 - Part 3: Update Currency to Number Input on SFAA FT 25/26 #4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ninosamson
commented
Jun 2, 2025
ninosamson
commented
- Final PR to update all currency inputs in FT25/26 to new number/currency input with proper validation
ninosamson
added
Form.io
ninosamson
changed the title
sh16011993
reviewed
Jun 2, 2025
| "decimalLimit": 2, | ||
| "requireDecimal": true | ||
| "type": "number", | ||
| "decimalLimit": 0, |
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
|
sh16011993
reviewed
Jun 2, 2025
| { | ||
| "label": "My total current year gross income is:", | ||
| "prefix": "$", | ||
| "customClass": "font-weight-bold", |
Collaborator
There was a problem hiding this comment.
We changed the component but do we want to get rid of this style? Likewise in other places.
Collaborator
Author
There was a problem hiding this comment.
We use that for all labels @sh16011993 it seems...
Collaborator
Author
There was a problem hiding this comment.
Upon reviewing further, the customClass for the number input which is implemented elsewhere is "CustomCSSClass"
Collaborator
There was a problem hiding this comment.
Thanks for confirming @dheepak-aot that we are trying to get rid of this style. Hence resolving this.
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
approved these changes
Jun 2, 2025
Collaborator
sh16011993
left a comment
sh16011993
left a comment
There was a problem hiding this comment.
Nice work @ninosamson 👍 LGTM
dheepak-aot
reviewed
Jun 2, 2025
| } | ||
| }, | ||
| { | ||
| "key": "parentResidencyExceptionSupportingDocumentsPanelContent", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.