Skip to content

Conversation

@ninosamson
Copy link
Collaborator

@ninosamson ninosamson commented Jun 6, 2025

Updates room and board questions:

  • Removes exception and uploader
  • Adds condition to only display to single/separated students
  • Adds question for self-contained suite
  • Updates paying rent question to show info banner to student to seek appeal if yes
  • Adds keys to consolidated data for assessment workflow

image

@ninosamson ninosamson self-assigned this Jun 6, 2025
@ninosamson ninosamson added Form.io Form IO definitions changed. Camunda Worflow Involves camunda workflow changes Form editor Tickets for ministry to implement using form editor. labels Jun 6, 2025
@ninosamson ninosamson marked this pull request as draft June 6, 2025 23:18
@ninosamson ninosamson marked this pull request as ready for review June 6, 2025 23:30
"label": "Will you be paying room and board (rent) to your parent(s)/step-parent/sponsor/legal guardian?",
"label": "Are you living independently in a self-contained suite?",
"optionsLabelPosition": "right",
"tooltip": "The suite has a separate entrance, kitchen, bathroom and living area/bedroom; and\r\n\r\nYou are paying fair market rent and responsible for your share of the utilities (hydro, telephone, cable, etc. if not included in rent).",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single \n instead of \r\n\r\n would be enough, and following other tooltips.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and updated! Was my error in the form editor.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.78% ( 4060 / 18642 )
Methods: 9.83% ( 234 / 2381 )
Lines: 25.11% ( 3507 / 13968 )
Branches: 13.91% ( 319 / 2293 )

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.51% ( 678 / 935 )
Methods: 73.45% ( 83 / 113 )
Lines: 74.58% ( 531 / 712 )
Branches: 58.18% ( 64 / 110 )

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.96% ( 1537 / 1788 )
Methods: 83.65% ( 174 / 208 )
Lines: 88.31% ( 1269 / 1437 )
Branches: 65.73% ( 94 / 143 )

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 72.27% ( 7038 / 9738 )
Methods: 70.1% ( 865 / 1234 )
Lines: 75.79% ( 5464 / 7209 )
Branches: 54.75% ( 709 / 1295 )

@sh16011993 sh16011993 self-requested a review June 9, 2025 18:58
],
"validate": {
"required": true,
"onlyAvailableItems": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ninosamson

@ninosamson ninosamson added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit fe7117f Jun 9, 2025
26 of 27 checks passed
@ninosamson ninosamson deleted the features/#4610-room-and-board branch June 9, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Camunda Worflow Involves camunda workflow changes Form editor Tickets for ministry to implement using form editor. Form.io Form IO definitions changed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants