Skip to content

Conversation

@bidyashish
Copy link
Contributor

@bidyashish bidyashish commented Jun 16, 2025

  • Change logic to expect ECE response file in IN folder with institution code in filename, rather than institution specific folder
  • Updates to change archive folder to "IN/Archive" from institution archive folder

Demo
image

@bidyashish bidyashish self-assigned this Jun 16, 2025
@bidyashish bidyashish force-pushed the feature/4664-PSI-Integration-Changes branch from 05797f9 to 2c190e0 Compare June 16, 2025 17:41
@bidyashish bidyashish marked this pull request as draft June 16, 2025 18:14
@bidyashish bidyashish force-pushed the feature/4664-PSI-Integration-Changes branch from a4d5a29 to 7475d2e Compare June 16, 2025 22:42
@bidyashish bidyashish marked this pull request as ready for review June 17, 2025 18:00
@bidyashish bidyashish changed the title 4664 - PSI Integration Changes - Filename and Folders - Part 2 #4664 - PSI Integration Changes - Filename and Folders - Part 2 Jun 17, 2025
@dheepak-aot dheepak-aot self-requested a review June 17, 2025 18:03
@sh16011993 sh16011993 requested review from sh16011993 June 17, 2025 23:40
institutionCode,
);

// If the file does not have integration location @hasIntegration true, skip the file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use user friendly names in comment. If the file does not have integration location hasIntegration flag set to true, skip the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dheepak-aot
Comments updated.

@sonarqubecloud
Copy link

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.72% ( 4092 / 18841 )
Methods: 9.72% ( 234 / 2407 )
Lines: 25.07% ( 3539 / 14119 )
Branches: 13.78% ( 319 / 2315 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.94% ( 717 / 983 )
Methods: 73.5% ( 86 / 117 )
Lines: 74.97% ( 563 / 751 )
Branches: 59.13% ( 68 / 115 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.42% ( 1547 / 1790 )
Methods: 84.62% ( 176 / 208 )
Lines: 88.74% ( 1277 / 1439 )
Branches: 65.73% ( 94 / 143 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 72.27% ( 7038 / 9738 )
Methods: 70.1% ( 865 / 1234 )
Lines: 75.79% ( 5464 / 7209 )
Branches: 54.75% ( 709 / 1295 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Looks good 👍

Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bidyashish. LGTM 👍

integrationContacts: true,
},
where: {
hasIntegration: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bidyashish bidyashish added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit d02015a Jun 18, 2025
22 checks passed
@bidyashish bidyashish deleted the feature/4664-PSI-Integration-Changes branch June 18, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants