-
Notifications
You must be signed in to change notification settings - Fork 13
#4664 - PSI Integration Changes - Filename and Folders - Part 2 #4828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
05797f9 to
2c190e0
Compare
a4d5a29 to
7475d2e
Compare
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Outdated
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Outdated
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Outdated
Show resolved
Hide resolved
...integrations/src/institution-integration/ece-integration/ece-response.integration.service.ts
Outdated
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Outdated
Show resolved
Hide resolved
.../integrations/src/institution-integration/ece-integration/ece-response.processing.service.ts
Outdated
Show resolved
Hide resolved
| institutionCode, | ||
| ); | ||
|
|
||
| // If the file does not have integration location @hasIntegration true, skip the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use user friendly names in comment. If the file does not have integration location hasIntegration flag set to true, skip the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dheepak-aot
Comments updated.
|
dheepak-aot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Looks good 👍
sh16011993
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @bidyashish. LGTM 👍
| integrationContacts: true, | ||
| }, | ||
| where: { | ||
| hasIntegration: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



Demo
