Skip to content

#4664 - PSI Integration Changes - Filename and Folders - Part 3 #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bidyashish merged 2 commits into from
Jun 16, 2025
Merged

#4664 - PSI Integration Changes - Filename and Folders - Part 3 #4829

bidyashish merged 2 commits into from
Jun 16, 2025

Conversation

@bidyashish
Copy link
Contributor

@bidyashish bidyashish commented Jun 16, 2025 •
edited
Loading

  • Changes the file path for IER so that files are generated in the OUT folder instead of institution specific folders

Demo
image

@bidyashish bidyashish self-assigned this Jun 16, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.71% ( 4093 / 18856 )
Methods: 9.71% ( 234 / 2410 )
Lines: 25.05% ( 3540 / 14130 )
Branches: 13.77% ( 319 / 2316 )

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.94% ( 717 / 983 )
Methods: 73.5% ( 86 / 117 )
Lines: 74.97% ( 563 / 751 )
Branches: 59.13% ( 68 / 115 )

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.42% ( 1547 / 1790 )
Methods: 84.62% ( 176 / 208 )
Lines: 88.74% ( 1277 / 1439 )
Branches: 65.73% ( 94 / 143 )

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 72.27% ( 7038 / 9738 )
Methods: 70.1% ( 865 / 1234 )
Lines: 75.79% ( 5464 / 7209 )
Branches: 54.75% ( 709 / 1295 )

@andrewsignori-aot andrewsignori-aot changed the title 4664 - PSI Integration Changes - Filename and Folders - Part 3 #4664 - PSI Integration Changes - Filename and Folders - Part 3 Jun 16, 2025
@sh16011993 sh16011993 self-requested a review June 16, 2025 21:09
sh16011993
sh16011993 approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@sh16011993 sh16011993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @bidyashish 👍

andrewsignori-aot
andrewsignori-aot approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bidyashish bidyashish added this pull request to the merge queue Jun 16, 2025
Merged via the queue into main with commit cb7a332 Jun 16, 2025
22 checks passed
@bidyashish bidyashish deleted the feature/4664-PSI-Integration-Changes-3 branch June 16, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sh16011993 sh16011993 sh16011993 approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@bidyashish bidyashish

Labels

E2E/Unit tests Queue Consumers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bidyashish @sh16011993 @andrewsignori-aot