Skip to content

Conversation

@ninosamson
Copy link
Collaborator

@ninosamson ninosamson commented Jun 20, 2025

Updates to content on modified independent questions on SFAA25/26 FT, including:

  • Update to header content for description of situation and supporting document uploader.
  • Adds panel for "Which of the following best describes your situation" question.

image

@ninosamson ninosamson self-assigned this Jun 20, 2025
@ninosamson ninosamson added Form.io Form IO definitions changed. Form editor Tickets for ministry to implement using form editor. labels Jun 20, 2025
@bidyashish bidyashish requested a review from Copilot June 20, 2025 22:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the form definition for the SFAA25/26 FT form by adding a new panel for the modified independent status and updating the header content of a supporting document uploader element.

  • Added a new "Modified Independent Status Panel" with conditional visibility based on the "estranged" field.
  • Removed redundant conditional logic from the radio component since its parent panel now manages its visibility.
  • Updated content text for the supporting documents section.
Comments suppressed due to low confidence (2)

sources/packages/forms/src/form-definitions/sfaa2025-26-ft.json:2543

  • [nitpick] The new panel's 'label' property is set to a generic 'Panel'. Consider renaming it to a more descriptive label that clearly reflects its purpose, such as 'Modified Independent Information Panel'.
            {

sources/packages/forms/src/form-definitions/sfaa2025-26-ft.json:2575

  • [nitpick] Removing the duplicate conditional block from the radio component appears intentional since the parent panel now manages visibility. Consider adding an inline comment to clarify this design decision for future maintainers.
                },

Copy link
Contributor

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sonarqubecloud
Copy link

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.71% ( 4088 / 18832 )
Methods: 9.72% ( 234 / 2408 )
Lines: 25.04% ( 3535 / 14116 )
Branches: 13.82% ( 319 / 2308 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.94% ( 717 / 983 )
Methods: 73.5% ( 86 / 117 )
Lines: 74.97% ( 563 / 751 )
Branches: 59.13% ( 68 / 115 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.42% ( 1547 / 1790 )
Methods: 84.62% ( 176 / 208 )
Lines: 88.74% ( 1277 / 1439 )
Branches: 65.73% ( 94 / 143 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 72.81% ( 7084 / 9729 )
Methods: 70.36% ( 869 / 1235 )
Lines: 76.3% ( 5500 / 7208 )
Branches: 55.6% ( 715 / 1286 )

@ninosamson ninosamson added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 9f9d736 Jun 20, 2025
26 of 27 checks passed
@ninosamson ninosamson deleted the features/#4842-mob-content-update branch June 20, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Form editor Tickets for ministry to implement using form editor. Form.io Form IO definitions changed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants