-
Notifications
You must be signed in to change notification settings - Fork 13
#4842 - Update modified independent content and layout #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the form definition for the SFAA25/26 FT form by adding a new panel for the modified independent status and updating the header content of a supporting document uploader element.
- Added a new "Modified Independent Status Panel" with conditional visibility based on the "estranged" field.
- Removed redundant conditional logic from the radio component since its parent panel now manages its visibility.
- Updated content text for the supporting documents section.
Comments suppressed due to low confidence (2)
sources/packages/forms/src/form-definitions/sfaa2025-26-ft.json:2543
- [nitpick] The new panel's 'label' property is set to a generic 'Panel'. Consider renaming it to a more descriptive label that clearly reflects its purpose, such as 'Modified Independent Information Panel'.
{
sources/packages/forms/src/form-definitions/sfaa2025-26-ft.json:2575
- [nitpick] Removing the duplicate conditional block from the radio component appears intentional since the parent panel now manages visibility. Consider adding an inline comment to clarify this design decision for future maintainers.
},
bidyashish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
|



Updates to content on modified independent questions on SFAA25/26 FT, including: