#4818 - Parent Declare - Supporting User Portal Update - Part 1

[bidyashish]

Update search for parent only

Demo

Error

E2E test will follow.

[Copilot]

Pull Request Overview

This PR adds support for Parent searches alongside Partner searches by introducing a full-name field, updating DTOs, and refactoring backend logic into a unified service method.

• Added “Parent’s full name” input in the UI and adjusted validation/labels
• Extended DTOs with optional parentFullName and made studentsDateOfBirth optional
• Refactored backend controllers to use a new getSupportingUserForApplication method and removed the old one

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
sources/packages/web/src/views/supporting-user/SupportingInformation.vue	UI: added Parent full name field, updated labels and form logic
sources/packages/web/src/services/http/dto/SupportingUser.dto.ts	Added parentFullName? and made studentsDateOfBirth? optional
sources/packages/backend/apps/api/src/services/supporting-user/supporting-user.service.ts	New getSupportingUserForApplication method, unified filtering
sources/packages/backend/apps/api/src/services/application/application.service.ts	Removed deprecated getApplicationForSupportingUser
sources/packages/backend/apps/api/src/route-controllers/supporting-user/...supporting-users.controller.ts	Updated controllers to call the new service method
sources/packages/backend/apps/api/src/route-controllers/supporting-user/models/supporting-user.dto.ts	Added optional fields to the API input DTO, adjusted validation

Comments suppressed due to low confidence (4)

sources/packages/web/src/views/supporting-user/SupportingInformation.vue:24

• The label passed to checkOnlyDigitsRule still reads 'Number' while the null/empty rule uses 'Application number'. Update this to 'Application number' for consistency.

                (v) => checkOnlyDigitsRule(v, 'Number'),

sources/packages/backend/apps/api/src/route-controllers/supporting-user/models/supporting-user.dto.ts:39

• The studentsDateOfBirth field is optional but has no format validation. Consider adding a decorator like @IsISO8601() or @IsDateString() to enforce a valid date format.

  studentsDateOfBirth?: string;

sources/packages/backend/apps/api/src/services/supporting-user/supporting-user.service.ts:277

• The new getSupportingUserForApplication method implements critical filtering logic for both Parent and Partner flows but lacks unit tests. Add tests covering both branches (with parentFullName and with studentsDateOfBirth).

  async getSupportingUserForApplication(

sources/packages/web/src/views/supporting-user/SupportingInformation.vue:361

• The supportingUserType prop is used in the template (v-if="supportingUserType === ...") but isn't exposed in the return of setup. Add supportingUserType: props.supportingUserType to the returned object.

    };

[sh16011993]

👍

[dheepak-aot]

Thanks for making the changes @bidyashish. Added some more comments.

[dheepak-aot]

Sorry about the confusion, the object must be typed with the DTO type, which in this case and on line 49 as well is ApplicationIdentifierAPIInDTO

@ValidateIf(
    (object: ApplicationIdentifierAPIInDTO) =>
      object.supportingUserType === SupportingUserType.Parent,
  )

[bidyashish]

Updated.

[dheepak-aot]

Thanks for making the changes @bidyashish. Left one last comment on class validator.

[sh16011993]

Nice work @bidyashish 👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	21.67% ( 4097 / 18905 )
Methods:	9.68% ( 234 / 2418 )
Lines:	25.02% ( 3544 / 14166 )
Branches:	13.74% ( 319 / 2321 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	72.94% ( 717 / 983 )
Methods:	73.5% ( 86 / 117 )
Lines:	74.97% ( 563 / 751 )
Branches:	59.13% ( 68 / 115 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	86.42% ( 1547 / 1790 )
Methods:	84.62% ( 176 / 208 )
Lines:	88.74% ( 1277 / 1439 )
Branches:	65.73% ( 94 / 143 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	73.22% ( 7201 / 9835 )
Methods:	70.83% ( 884 / 1248 )
Lines:	76.63% ( 5581 / 7283 )
Branches:	56.44% ( 736 / 1304 )