-
Notifications
You must be signed in to change notification settings - Fork 13
#366 - v2.12.0 - Cherry Pick to include GL Date #4530 #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# CAS GL Date update ## GL date sent to CAS - [x] The `GL date` that is set in the payload of CAS API call has been `CAS invoice batch - creation date`, which is now updated to the date when the CAS API is called to send the invoice(the current date at the moment is converted to BC date). - [x] As we do not have a particular column to capture the date that an invoice is successfully sent to CAS, a new column `date_sent` is created in `sims.cas_invoices` table. - [x] For those invoices which are already sent to CAS, the date_sent is set from `invoice_status_updated_on`(mainly for handling existing production data). ## GL date displayed in report - [x] The GL Date displayed in the report is not updated to use `date_sent` if present and `n/a` otherwise. Report with pending invoice. <img width="1607" height="307" alt="image" src="https://github.com/user-attachments/assets/7c109ba0-b983-4e60-b338-d2a7fbdfa0a2" /> Report with Sent invoice, <img width="1260" height="173" alt="image" src="https://github.com/user-attachments/assets/f507b894-afa4-40d4-b558-999c392aab45" /> ## Rollback evidence <img width="949" height="584" alt="image" src="https://github.com/user-attachments/assets/9e43e0f4-6a0f-4c38-959f-275f75f17133" /> ## E2E Tests Updated E2E test for both API and Queue Consumers
|
ninosamson
approved these changes
Jul 15, 2025
Collaborator
ninosamson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
dheepak-aot
approved these changes
Jul 15, 2025
Collaborator
dheepak-aot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.