Skip to content

Conversation

@CarlyCotton
Copy link
Collaborator

@CarlyCotton CarlyCotton commented Jul 15, 2025

  • bringing CAS GL Date into v2.12.0 (currently only deployed to test)

# CAS GL Date update

## GL date sent to CAS

- [x] The `GL date` that is set in the payload of CAS API call has been
`CAS invoice batch - creation date`, which is now updated to the date
when the CAS API is called to send the invoice(the current date at the
moment is converted to BC date).
- [x] As we do not have a particular column to capture the date that an
invoice is successfully sent to CAS, a new column `date_sent` is created
in `sims.cas_invoices` table.
- [x] For those invoices which are already sent to CAS, the date_sent is
set from `invoice_status_updated_on`(mainly for handling existing
production data).

## GL date displayed in report
- [x] The GL Date displayed in the report is not updated to use
`date_sent` if present and `n/a` otherwise.

Report with pending invoice. 
<img width="1607" height="307" alt="image"
src="https://github.com/user-attachments/assets/7c109ba0-b983-4e60-b338-d2a7fbdfa0a2"
/>

Report with Sent invoice,

<img width="1260" height="173" alt="image"
src="https://github.com/user-attachments/assets/f507b894-afa4-40d4-b558-999c392aab45"
/>


## Rollback evidence

<img width="949" height="584" alt="image"
src="https://github.com/user-attachments/assets/9e43e0f4-6a0f-4c38-959f-275f75f17133"
/>

## E2E Tests

Updated E2E test for both API and Queue Consumers
@sonarqubecloud
Copy link

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.66% ( 4092 / 18889 )
Methods: 9.68% ( 234 / 2418 )
Lines: 25.02% ( 3539 / 14146 )
Branches: 13.72% ( 319 / 2325 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 72.94% ( 717 / 983 )
Methods: 73.5% ( 86 / 117 )
Lines: 74.97% ( 563 / 751 )
Branches: 59.13% ( 68 / 115 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.43% ( 1548 / 1791 )
Methods: 84.62% ( 176 / 208 )
Lines: 88.75% ( 1278 / 1440 )
Branches: 65.73% ( 94 / 143 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 73.37% ( 7198 / 9811 )
Methods: 70.83% ( 884 / 1248 )
Lines: 76.83% ( 5576 / 7258 )
Branches: 56.55% ( 738 / 1305 )

@CarlyCotton CarlyCotton changed the base branch from main to release/v2.12.0 July 15, 2025 20:09
@CarlyCotton CarlyCotton added the Branch Sync-up Branch features move between main/release/hotfix branches. label Jul 15, 2025
@CarlyCotton CarlyCotton self-assigned this Jul 15, 2025
@CarlyCotton CarlyCotton marked this pull request as ready for review July 15, 2025 20:11
@CarlyCotton CarlyCotton changed the title v2.12.0 - Cherry Pick to include #4530 #366 v2.12.0 - Cherry Pick to include #4530 Jul 15, 2025
Copy link
Collaborator

@ninosamson ninosamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dheepak-aot dheepak-aot self-requested a review July 15, 2025 21:10
@dheepak-aot dheepak-aot changed the title #366 v2.12.0 - Cherry Pick to include #4530 #366 - v2.12.0 - Cherry Pick to include #4530 Jul 15, 2025
@dheepak-aot dheepak-aot changed the title #366 - v2.12.0 - Cherry Pick to include #4530 #366 - v2.12.0 - Cherry Pick to include GL Date #4530 Jul 15, 2025
Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@CarlyCotton CarlyCotton merged commit b6403ee into release/v2.12.0 Jul 15, 2025
22 checks passed
@CarlyCotton CarlyCotton deleted the v2.12.0-Cherry-Pick-for-GL-Date branch July 15, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Branch Sync-up Branch features move between main/release/hotfix branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants