#4471 - BCSC - Enable using the address from BCSC in SIMS profile #5001
Conversation
bidyashish
force-pushed
the
feature/4471-BCSC-Enable-address
branch
from
db9458e to
4dc9726
Compare
bidyashish
changed the title
| bcscParsedToken.address.country.toLowerCase() === "ca" || | ||
| bcscParsedToken.address.country.toLowerCase() === "canada" |
There was a problem hiding this comment.
Is there any expectation to receive "ca" and "canada" as a country?
If not, please use the xpcetd one only and have it declared as a constant.
There was a problem hiding this comment.
Thanks @andrewsignori-aot ,
Code updated.
| const studentStore = useStudentStore(); | ||
| const processing = ref(false); | ||
| const populateBcscAddressFields = (data: StudentProfileFormModel) => { |
There was a problem hiding this comment.
BCSC goes uppercase for this name: populateBCSCAddressFields.
There was a problem hiding this comment.
Thanks @andrewsignori-aot ,
Code updated.
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice work, please take a look at the comments.
| if (bcscParsedToken.address.street_address) { | ||
| const normalizedAddress = | ||
| bcscParsedToken.address.street_address.replace(/\\n/g, "\n"); | ||
| const addressParts = normalizedAddress.split("\n"); | ||
| data.addressLine1 = addressParts[0]; | ||
| if (addressParts.length > 1) { | ||
| data.addressLine2 = addressParts.slice(1).join("\n"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested code:
if (bcscParsedToken.address.street_address) {
const [address1, address2] =
bcscParsedToken.address.street_address.split("\n");
data.addressLine1 = address1?.trim();
data.addressLine2 = address2?.trim();
}There was a problem hiding this comment.
We don't need it anymore this logic as we are populate all in addressLine1.
sh16011993
left a comment
sh16011993
left a comment
There was a problem hiding this comment.
Nice work @bidyashish 👍
| const processing = ref(false); | ||
| const populateBCSCAddressFields = (data: StudentProfileFormModel) => { | ||
| if (!bcscParsedToken.address) return; |
There was a problem hiding this comment.
If bcscParsedToken.address is no longer optional, the check can be removed.
| data.provinceState = bcscParsedToken.address.region; | ||
| data.canadaPostalCode = bcscParsedToken.address.postal_code; | ||
| data.country = bcscParsedToken.address.country; | ||
| data.selectedCountry = |
There was a problem hiding this comment.
Minor, the "CA" can be added as a const.
There was a problem hiding this comment.
"CA" moved to system const.
| data.provinceState = bcscParsedToken.address.region; | ||
| data.canadaPostalCode = bcscParsedToken.address.postal_code; |
There was a problem hiding this comment.
Is this respecting the below AC?
For address info that is non-Canadian: bring over the street address, city, country
There was a problem hiding this comment.
Thanks,.
Updated the code.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice work, thanks for making the changes, looks good 👍
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
AC
Update keycloak to accept new fields from BCSC logins (BCSC in DEV/TEST are currently configured to send these fields)
Keycloak
Dev Done ✅
Pending:
Test/Staging
Prod
Demo
Keycloack Demo