#4941 - Approved exception does not repeat - Student Application Form #5051
Conversation
…d-exception-does-not-repeat-form-definition-ft
There was a problem hiding this comment.
Pull Request Overview
This PR resolves issue #4941 by preventing duplicate exception approvals in the Student Application Form and implementing structural improvements to exception handling.
- Increased JSON payload size limit from 200KB to 300KB to accommodate larger form data
- Restructured exception fields into container components with dedicated description fields
- Updated workflow to support data from both new container and legacy field structures
- Enhanced exception note handling with better categorization and messaging
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sfaa2025-26-ft.json | Restructured all exception fields into containers with dedicated description fields and full name context |
| load-assessment-consolidated-data.bpmn | Added fallback logic to read data from both new container and legacy field structures |
| application-exception.service.ts | Changed note type from General to Application and improved exception count messaging |
| form.dto.ts | Updated JSON size validation from 200KB to 300KB limit |
| class-validator-constants.ts | Increased JSON constant from 200KB to 300KB |
| app.module.ts | Updated body parser limit to use new 300KB constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...es/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/sfaa2025-26-ft.json
Outdated
Show resolved
Hide resolved
| "lockKey": true, | ||
| "customConditional": "show = data.studyEndDateBeforeSixWeeksFromToday || data.selectedStudyEndDateBeforeSixWeeksFromToday;", | ||
| "calculateServer": true | ||
| "customConditional": "show = !data.isProgramSectionReadOnly && !!data.selectedStudyEndDateBeforeSixWeeksFromToday;", |
| "type": "columns", | ||
| "columns": [ | ||
| "label": "Exception Description - Dependant's income tax", | ||
| "calculateValue": "value = `Dependant's income tax - ${data.dependants[rowIndex].fullName}`;", |
There was a problem hiding this comment.
Will row.fullName name work instead? same in other places
There was a problem hiding this comment.
Apparently, the container adds some isolation that makes this not work.
| "type": "columns", | ||
| "columns": [ | ||
| "label": "Exception Description - Dependant's income tax", | ||
| "calculateValue": "value = `Dependant's income tax - ${data.dependants[rowIndex].fullName}`;", |
There was a problem hiding this comment.
Is there a business consideration to include the date of birth to the description?
There was a problem hiding this comment.
Not so far.
sh16011993
left a comment
sh16011993
left a comment
There was a problem hiding this comment.
Great work @andrewsignori-aot 👍 Thanks for the doubt clarification.
...es/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn
Show resolved
Hide resolved
...es/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn
Show resolved
Hide resolved
|
Great work and great progress with the new exception framework. Please take a look at the comments. |
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for making the changes. Looks good 👍
E2E SIMS API Coverage Report
|
andrewsignori-aot
deleted the
feature/#4941-approved-exception-does-not-repeat-form-definition-ft
branch
Uh oh!
There was an error while loading. Please reload this page.