#4871 - Incorporate FT UC weeks from legacy while triggering SSR restriction #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_legacy' into 4871_incorporate_ft_UC_weeks_from_legacy
sh16011993
changed the title
dheepak-aot
reviewed
Aug 14, 2025
Comment on lines
615
to
638
| if (offeringIntensity) { | ||
| queryBuilder.andWhere( | ||
| "application.offeringIntensity = :offeringIntensity", | ||
| { | ||
| offeringIntensity, | ||
| }, | ||
| ); | ||
| // If offeringIntensity is specified, return only the sum for that intensity. | ||
| const result = await queryBuilder | ||
| .groupBy("application.offeringIntensity") | ||
| .getRawOne<ScholasticStandingSummary>(); | ||
| // If fullTime, add SFAS weeks. | ||
| if (offeringIntensity === OfferingIntensity.fullTime) { | ||
| const sfasUnsuccessfulCompletionWeeks = | ||
| await this.sfasIndividualService.getSFASTotalUnsuccessfulCompletionWeeks( | ||
| studentId, | ||
| ); | ||
| return { | ||
| fullTimeUnsuccessfulCompletionWeeks: | ||
| sfasUnsuccessfulCompletionWeeks + | ||
| (result?.totalUnsuccessfulWeeks ?? 0), | ||
| }; | ||
| } | ||
| } else { |
Collaborator
There was a problem hiding this comment.
Looks like there is a misunderstanding from dev syncup regarding the filter.
I will not consider using the filter as a blocker. But if the filter is used, it must be used only to restrict the FT legacy query which is always required as of now.
Hence, it would recommend not to change any logic or introduce filter but just centralize the logic.
I infer the same from the technical context in the ticket.
@andrewsignori-aot @bidyashish let me know if you have a different understanding.
dheepak-aot
reviewed
Aug 14, 2025
...d/apps/api/src/services/student-scholastic-standings/student-scholastic-standings.service.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Aug 14, 2025
...nd/apps/api/src/services/student-scholastic-standings/student-scholastic-standings.models.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Aug 15, 2025
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
dheepak-aot
approved these changes
Aug 15, 2025
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Nice work @sh16011993 . Looks good 👍
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following were completed:
getScholasticStandingSummarymethod of thestudent-scholastic-standings.service.tsgetSFASTotalUnsuccessfulCompletionWeeksmethod inside thegetScholasticStandingSummarymethod.getScholasticStandingSummarymethod and remove thegetTotalFullTimeUnsuccessfulWeeks, replacing it with thegetScholasticStandingSummary.