Skip to content

Conversation

@andrewsignori-aot
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot commented Aug 21, 2025

  • Changed the approach to generate exception information for dependents, swapping the container for a regular hidden field that produces the same JSON output to be saved to the DB. Kudos to @dheepak-aot for providing the solution. See below the new hidden field content, named with the same name as the previous exception container.
value = {
 exceptionDescription: `Dependant's income tax - ${data.dependants[rowIndex].fullName}`,
 pdDependentUpload: data.dependants[rowIndex]["pdDependentUpload"]
}
  • Update existing custom components and create an additional one with a complete schema.

Updated Schema

image

New Full Schema

image

@andrewsignori-aot andrewsignori-aot self-assigned this Aug 21, 2025
@andrewsignori-aot andrewsignori-aot added Web portal Form editor Tickets for ministry to implement using form editor. labels Aug 21, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.46% ( 4118 / 19186 )
Methods: 9.52% ( 233 / 2447 )
Lines: 24.83% ( 3565 / 14358 )
Branches: 13.44% ( 320 / 2381 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 74.3% ( 896 / 1206 )
Methods: 77.14% ( 108 / 140 )
Lines: 77.16% ( 696 / 902 )
Branches: 56.1% ( 92 / 164 )

@andrewsignori-aot andrewsignori-aot changed the title #5065 - Exceptions not repeat 25-26 backwards compatibility - Custom Components #5065 - Exceptions not repeat 25-26 backwards compatibility - Fix Dependents and Custom Components Aug 21, 2025
@andrewsignori-aot andrewsignori-aot marked this pull request as ready for review August 21, 2025 23:01
@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.43% ( 1548 / 1791 )
Methods: 84.62% ( 176 / 208 )
Lines: 88.75% ( 1278 / 1440 )
Branches: 65.73% ( 94 / 143 )

@dheepak-aot dheepak-aot self-requested a review August 21, 2025 23:05
@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 74.02% ( 7372 / 9960 )
Methods: 71.6% ( 900 / 1257 )
Lines: 77.44% ( 5709 / 7372 )
Branches: 57.33% ( 763 / 1331 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the additional step for dependants exception and creating and updating the form.io component. Looks good 👍

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the approach for handling exception information for dependents by replacing container components with regular hidden fields that generate the same JSON output for database storage. The changes address backwards compatibility issues for forms version 25-26.

  • Replaced exception containers with hidden fields that produce equivalent JSON output
  • Updated existing custom components to use the new hidden field approach
  • Added a new full schema custom component with complete form elements

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sims-components.ts Exports the new APPLICATION_EXCEPTION_FULL_SCHEMA component
application-exception.ts Updates existing component and adds full schema variant with complete form structure
sfaa2025-26-pt.json Converts dependent exception containers to hidden fields with calculated values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

customClass: "font-weight-bold",
hideLabel: true,
storage: "url",
dir: "Update to something meaningful to be saved to student files table.",
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory path 'Update to something meaningful to be saved to student files table.' is a placeholder comment that should be replaced with the actual directory path for file uploads.

Suggested change
dir: "Update to something meaningful to be saved to student files table.",
dir: "student/exception-documents",

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice work

@andrewsignori-aot
Copy link
Collaborator Author

Thanks for taking the additional step for dependants exception and creating and updating the form.io component. Looks good 👍

Thanks for looking into it and finding the alternative solution 😉

@andrewsignori-aot andrewsignori-aot added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 019ac1c Aug 21, 2025
26 of 27 checks passed
@andrewsignori-aot andrewsignori-aot deleted the feature/#5065-exceptions-not-repeat-formio-custom-component branch August 21, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Form editor Tickets for ministry to implement using form editor. Web portal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants