#4572 - Aviation Offering (e2e tests) #5181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
changed the title
.../_tests_/e2e/education-program-offering.institutions.controller.validateOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../_tests_/e2e/education-program-offering.institutions.controller.validateOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../_tests_/e2e/education-program-offering.institutions.controller.validateOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
.../_tests_/e2e/education-program-offering.institutions.controller.validateOffering.e2e-spec.ts
Outdated
Show resolved
Hide resolved
Collaborator
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice work, please take a look at the comments.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
andrewsignori-aot
approved these changes
Sep 16, 2025
Collaborator
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Thanks for making the changes, looks good 👍
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
CarlyCotton
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following e2e tests have been written:
EducationProgramOfferingInstitutionsController(e2e)-validateOffering
√ Should return warning when a full-time program is not an aviation program but has an aviation offering.
√ Should return warning when a part-time program is an aviation program and has an aviation offering with a non matching aviation credential type.
√ Should return warning when a full-time program is an aviation program and has an aviation offering with funded weeks being more than the maximum allowed funded weeks for this aviation credential type.
√ Should return warning when a part-time program is an aviation program and has an aviation offering with a private pilot training aviation credential type.
√ Should return error when a full-time program is an aviation program and has an aviation offering that is not one of the allowed aviation credential type - private pilot training, instructors rating, commercial pilot training or endorsements.
√ Should return error when a full-time program is an aviation program and offering is not selected as one of the following options: yes,no.
Screenshot: