#4726 - Institution based BETA - Backend #5213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements institution-based BETA functionality for the backend system, allowing the restriction of full-time application submissions to designated beta institutions only when the feature flag is enabled.
- Adds a new database column
is_beta_institutionto track beta institution status - Implements validation logic to restrict full-time applications to beta institutions when the feature flag is active
- Updates APIs to filter institution options based on beta status for full-time offerings
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sources/packages/backend/libs/sims-db/src/entities/institution-location.model.ts | Adds isBetaInstitution boolean column to the InstitutionLocation entity |
| sources/packages/backend/apps/db-migrations/src/migrations/1758903872348-InstitutionLocationsAddColIsBetaInstitution.ts | Database migration to add the beta institution column |
| sources/packages/backend/libs/utilities/src/config/config.service.ts | Adds configuration property for the beta institutions feature flag |
| sources/packages/backend/apps/api/src/services/application/application.service.ts | Implements validation logic to restrict applications to beta institutions |
| sources/packages/backend/apps/api/src/route-controllers/institution-locations/institution-location.students.controller.ts | Updates options API to filter beta institutions based on offering intensity |
| sources/packages/backend/apps/api/src/services/institution-location/institution-location.service.ts | Adds beta institution filtering to designated locations query |
| Multiple deployment files | Adds ALLOW_BETA_INSTITUTIONS_ONLY environment variable configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts
Show resolved
Hide resolved
Comment on lines
+40
to
+41
| @Query("offeringIntensity", new ParseEnumQueryPipe(OfferingIntensity)) | ||
| offeringIntensity?: OfferingIntensity, |
There was a problem hiding this comment.
The new query parameter offeringIntensity lacks API documentation. Consider adding OpenAPI decorators like @ApiQuery() to document this optional parameter, its purpose, and possible values for API consumers.
andrewsignori-aot
approved these changes
Sep 26, 2025
Collaborator
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Great work, looks good 👍
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
|
andrewsignori-aot
approved these changes
Sep 26, 2025
Collaborator
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Reviewed after column renamed to is_beta, looks good 👍
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
ninosamson
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB Migration
is_betato the tablesims.institution_locationsto identify the beta institutions.Rollback evidence
API
offeringIntensityto limit the results to beta institutions forfull-timeif the beta institutions flag is enabled.full-timeif the beta institutions flag is enabled.New environment variable
ALLOW_BETA_INSTITUTIONS_ONLYis added to the code and also to github variables inDEV.