#4441 - Fix supporting partner dynamic tax year #5413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 5fffabd Merge: 2a95119 e797473 Author: Tiago Graf <tiago.graf@quartech.com> Date: Tue Nov 25 10:10:10 2025 -0800 Merge branch 'main' into bugs/#4441-supporting-user-dynamic-year commit 2a95119 Author: Tiago Graf <tiago.graf@quartech.com> Date: Tue Nov 25 10:05:39 2025 -0800 Add program start date to get supporting user details commit 4ca463a Author: Tiago Graf <tiago.graf@quartech.com> Date: Fri Nov 21 13:25:00 2025 -0800 Removed unused imports commit 84690f5 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Fri Nov 21 12:20:07 2025 -0800 Update Applications.vue commit 161d798 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Fri Nov 21 12:07:30 2025 -0800 Refactoring to use new student getter commit f30ea3b Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Fri Nov 21 09:18:08 2025 -0800 Add a student store getter for valid sin commit 0d45dc9 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 16:31:40 2025 -0800 Update studentwelcomepage.json commit 3933378 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 16:24:17 2025 -0800 Update studentwelcomepage.json commit ed8df83 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 12:48:07 2025 -0800 lint fix commit 41041d1 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 12:44:03 2025 -0800 Update studentwelcomepage.json commit 18cecc1 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 12:11:03 2025 -0800 Updated student welcome page formio commit e17c99b Merge: 8506569 b93dedd Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 11:04:17 2025 -0800 Merge branch 'bug/#5393-student-start-application-enabled' of https://github.com/bcgov/SIMS into bug/#5393-student-start-application-enabled commit b93dedd Author: Tiago Graf <tiago.graf@quartech.com> Date: Thu Nov 20 11:01:06 2025 -0800 Update sources/packages/web/src/views/student/financial-aid-application/StudentApplication.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 4583a0f Author: Tiago Graf <tiago.graf@quartech.com> Date: Thu Nov 20 11:00:08 2025 -0800 Update sources/packages/web/src/views/student/financial-aid-application/StudentApplication.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 9d2d692 Author: Tiago Graf <tiago.graf@quartech.com> Date: Thu Nov 20 10:59:35 2025 -0800 Update sources/packages/web/src/views/student/financial-aid-application/StudentApplication.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 6dce21d Author: Tiago Graf <tiago.graf@quartech.com> Date: Thu Nov 20 10:54:13 2025 -0800 Update sources/packages/web/src/views/student/financial-aid-application/StudentApplication.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 8506569 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 09:52:12 2025 -0800 Removed double import commit 1492232 Author: Tiago Graf <Tiago.Graf@gov.ab.ca> Date: Thu Nov 20 09:38:49 2025 -0800 Disable Start Application button if invalid SIN
dheepak-aot
reviewed
Nov 25, 2025
...es/backend/apps/api/src/route-controllers/supporting-user/supporting-user.aest.controller.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the dynamic tax year (CalculatedTaxYear) was not displaying correctly on the supporting user (partner) application form in the ministry portal. The fix adds programYear.startDate to the data retrieved when loading supporting user details.
Key Changes
- Added
programYear.startDateto the database query inSupportingUserService.getSupportingUsersDetails() - Exposed
programYearStartDatein the controller response and DTO - Updated the e2e test to assert the new field is returned
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| supporting-user.service.ts | Added programYear.startDate to the select fields in the getSupportingUsersDetails() query |
| supporting-user.aest.controller.ts | Mapped programYearStartDate from the application's program year to the response DTO |
| supporting-user.dto.ts | Added programYearStartDate property to SupportingUserFormDataAPIOutDTO |
| supporting-user.aest.controller.getIdentifiableSupportingUser.e2e-spec.ts | Updated test assertion to verify the programYearStartDate field is returned correctly |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...ackages/backend/apps/api/src/route-controllers/supporting-user/models/supporting-user.dto.ts
Show resolved
Hide resolved
dheepak-aot
approved these changes
Nov 25, 2025
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Good work @tiago-graf thanks for the making the change.
…ting-user/models/supporting-user.dto.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
weskubo-cgi
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
programYear.startDatewhen loading the details for the supported user. This fixed the dynamic year (CalculatedTaxYear) not showing up on the supporting user (partner) application form on the ministry portal.