#4398 - Replace PrimeVue tables - Part One #5427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 25, 2025 14:23
Minor refactoring and formatting updates.
Added mobile support Overawards and Search Students.
Updated type on studentFileUploads to fix TS error.
Updated DestinationAgreementSummary and Restrictions (Institution).
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates 11 Vue components from PrimeVue DataTable to Vuetify v-data-table, modernizing the table implementations across student, institution, and ministry views.
Key changes:
- Replaced PrimeVue
<DataTable>and<Column>components with Vuetify<v-data-table>and slot-based templates - Converted prop names from camelCase to kebab-case (e.g.,
subTitle→sub-title,recordsCount→records-count) - Added data table header definitions to
DataTableContract.tsfor all migrated tables - Updated DTOs to include missing fields (
updatedAtinRestrictionSummaryAPIOutDTO,createdAtinOverawardAPIOutDTO) - Added explicit messages to
toggle-contentcomponents for better UX - Improved performance by converting array filtering to Set-based lookups in OverawardDetails
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| OfferingsUpload.vue | Migrated offerings upload validation table to Vuetify with proper headers and template slots |
| SINManagement.vue | Converted SIN validations table with all columns properly mapped |
| Restrictions.vue (institution) | Migrated institution restrictions table with consistent logic |
| PendingDesignation.vue | Updated pending designations table with proper headers |
| SearchInstitutions.vue | Converted institution search results table |
| DataTableContract.ts | Added header definitions for all new Vuetify tables with JSDoc comments |
| Restriction.dto.ts | Added missing updatedAt field to support resolved date display |
| Overaward.dto.ts | Added missing createdAt field for date-added fallback logic |
| DesignationAgreementSummary.vue | Migrated designation requests table with improved imports organization |
| StudentRestrictions.vue | Converted student restrictions table (logic inconsistency found) |
| StudentFileUploads.vue | Migrated file uploads table with conditional column (header mismatch found) |
| SearchStudents.vue | Updated student search results table |
| OverawardDetails.vue | Migrated overawards and deductions tables (missing column found) |
| StudentLoanBalancePartTime.vue | Converted part-time loan balance table |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
sources/packages/web/src/components/common/students/StudentFileUploads.vue
Show resolved
Hide resolved
sources/packages/web/src/components/common/students/StudentRestrictions.vue
Outdated
Show resolved
Hide resolved
TS type fix.
weskubo-cgi
commented
Nov 29, 2025
| <template #[`item.overawardOrigin`]="{ item }"> | ||
| {{ item.overawardOrigin }} | ||
| </template> | ||
| <template v-if="showAddedBy" #[`item.addedByUser`]="{ item }"> |
Collaborator
Author
There was a problem hiding this comment.
The v-if is not technically required with conditional headers but I left in for clarity.
weskubo-cgi
added
Good first issue
dheepak-aot
reviewed
Dec 1, 2025
sources/packages/web/src/components/aest/students/StudentLoanBalancePartTime.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 1, 2025
sources/packages/web/src/components/common/students/StudentFileUploads.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 1, 2025
dheepak-aot
reviewed
Dec 1, 2025
dheepak-aot
reviewed
Dec 1, 2025
sources/packages/web/src/components/common/students/StudentRestrictions.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 2, 2025
dheepak-aot
reviewed
Dec 2, 2025
tiago-graf
approved these changes
Dec 2, 2025
dheepak-aot
reviewed
Dec 2, 2025
...ackages/web/src/components/partial-view/DesignationAgreement/DesignationAgreementSummary.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 2, 2025
sources/packages/web/src/views/aest/institution/PendingDesignation.vue
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Dec 2, 2025
dheepak-aot
reviewed
Dec 2, 2025
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
weskubo-cgi
changed the title
dheepak-aot
approved these changes
Dec 2, 2025
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for making the changes. Looks good 👍
weskubo-cgi
deleted the
feature/#4398-replace-primevue-tables-round-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The following components were updated from Primevue to Vuetify:
Some supporting changes that were also made:
Existing issues with prop validation (String in place of Number) were not addressed since this PR already impacts a large number of files. Suggest handling in a separate PR.
Screenshots
Ministry
Search Students
Student Details - File Uploads
Student Details - Social Insurance Number
Student Details - Balances
Search Institutions
Institution Details - Designations
Institution Details - Restrictions
Designation Requests
Institution
Offerings Upload
Students - File Uploads
See Ministry/Students - File Uploads
Students - Balances
See Ministry/Students - Balances
Students
Overawards Balance
See Ministry/Students - Balances