Skip to content

Conversation

@weskubo-cgi
Copy link
Collaborator

@weskubo-cgi weskubo-cgi commented Jan 27, 2026

Overview

  • Replaced ptib with ptiru in three forms.
  • Migrated existing Institution and EducationProgram data from ptib to ptiru.
  • Issue with regulatory body codes displaying in lower case in View Institution Profile will be addressed in Institution types remodel PART 1 #5645.

Screenshots

Ministry

View Institution Profile

image

Edit Institution Profile

image

Create Institution

image

Institution

Create/Edit Program

image

Migration Rollback

image image

@weskubo-cgi weskubo-cgi self-assigned this Jan 27, 2026
@weskubo-cgi weskubo-cgi added Web portal Form.io Form IO definitions changed. DB DB migration involved labels Jan 27, 2026
@weskubo-cgi weskubo-cgi requested a review from Copilot January 27, 2026 20:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request renames the regulatory body designation from "PTIB" (Private Training Institutions Branch) to "PTIRU" (Private Training Institutions Regulation Unit) across the system. This is a straightforward rename that affects form definitions and requires data migration for existing records.

Changes:

  • Updated three form.io JSON definitions to change the label from "PTIB" to "PTIRU" and the value from "ptib" to "ptiru"
  • Created database migrations to update existing Institution and EducationProgram records from "ptib" to "ptiru"
  • Added validateWhenHidden: false property to the regulatory body fields in the forms

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sources/packages/forms/src/form-definitions/institutionprofilecreation.json Updated regulatory body dropdown to show "PTIRU" instead of "PTIB" and added validateWhenHidden property
sources/packages/forms/src/form-definitions/institutionprofile.json Updated regulatory body dropdown to show "PTIRU" instead of "PTIB" and added validateWhenHidden property
sources/packages/forms/src/form-definitions/educationprogram.json Updated regulatory body dropdown to show "PTIRU" instead of "PTIB", added validateWhenHidden property, and reorganized hideLabel property position
sources/packages/backend/apps/db-migrations/src/sql/Institution/Rollback-rename-regulating-body-ptib-to-ptiru.sql Rollback script to revert regulating_body from 'ptiru' back to 'ptib' in institutions table
sources/packages/backend/apps/db-migrations/src/sql/Institution/Rename-regulating-body-ptib-to-ptiru.sql Migration script to update regulating_body from 'ptib' to 'ptiru' in institutions table
sources/packages/backend/apps/db-migrations/src/sql/EducationPrograms/Rollback-rename-regulatory-body-ptib-to-ptiru.sql Rollback script to revert regulatory_body from 'ptiru' back to 'ptib' in education_programs table
sources/packages/backend/apps/db-migrations/src/sql/EducationPrograms/Rename-regulatory-body-ptib-to-ptiru.sql Migration script to update regulatory_body from 'ptib' to 'ptiru' in education_programs table
sources/packages/backend/apps/db-migrations/src/migrations/1769465086815-UpdateEducationProgramRegulatoryBody.ts TypeScript migration class to execute the education program regulatory body update
sources/packages/backend/apps/db-migrations/src/migrations/1769465037191-UpdateInstitutionRegulatingBody.ts TypeScript migration class to execute the institution regulating body update

@sonarqubecloud
Copy link

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.18% ( 4321 / 21410 )
Methods: 9.69% ( 253 / 2611 )
Lines: 24.35% ( 3710 / 15237 )
Branches: 10.05% ( 358 / 3562 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 75.41% ( 1055 / 1399 )
Methods: 79.31% ( 115 / 145 )
Lines: 78.79% ( 769 / 976 )
Branches: 61.51% ( 171 / 278 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.68% ( 1616 / 1886 )
Methods: 85% ( 187 / 220 )
Lines: 88.64% ( 1287 / 1452 )
Branches: 66.36% ( 142 / 214 )

@weskubo-cgi weskubo-cgi changed the title Feature/#5581 ptib to ptiru #5581 - PTIRU to replace PTIB for Education Programs/Institutions Jan 27, 2026
@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 77.2% ( 8827 / 11434 )
Methods: 76.66% ( 1041 / 1358 )
Lines: 81.24% ( 6408 / 7888 )
Branches: 62.98% ( 1378 / 2188 )

"validate": {
"required": true
},
"validateWhenHidden": false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added on save. If there's any risk to this change I can remove. This does seem to be standard in forms.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues. Forms that are not updated frequently may have these changes. It usually reflects the default value of the property.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good 👍

"validate": {
"required": true
},
"validateWhenHidden": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues. Forms that are not updated frequently may have these changes. It usually reflects the default value of the property.

@weskubo-cgi weskubo-cgi enabled auto-merge January 27, 2026 23:21
@weskubo-cgi weskubo-cgi added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 5c918a8 Jan 28, 2026
22 checks passed
@weskubo-cgi weskubo-cgi deleted the feature/#5581-ptib-to-ptiru branch January 28, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB DB migration involved Form.io Form IO definitions changed. Web portal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants