-
Notifications
You must be signed in to change notification settings - Fork 13
#5581 - PTIRU to replace PTIB for Education Programs/Institutions #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request renames the regulatory body designation from "PTIB" (Private Training Institutions Branch) to "PTIRU" (Private Training Institutions Regulation Unit) across the system. This is a straightforward rename that affects form definitions and requires data migration for existing records.
Changes:
- Updated three form.io JSON definitions to change the label from "PTIB" to "PTIRU" and the value from "ptib" to "ptiru"
- Created database migrations to update existing Institution and EducationProgram records from "ptib" to "ptiru"
- Added
validateWhenHidden: falseproperty to the regulatory body fields in the forms
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sources/packages/forms/src/form-definitions/institutionprofilecreation.json | Updated regulatory body dropdown to show "PTIRU" instead of "PTIB" and added validateWhenHidden property |
| sources/packages/forms/src/form-definitions/institutionprofile.json | Updated regulatory body dropdown to show "PTIRU" instead of "PTIB" and added validateWhenHidden property |
| sources/packages/forms/src/form-definitions/educationprogram.json | Updated regulatory body dropdown to show "PTIRU" instead of "PTIB", added validateWhenHidden property, and reorganized hideLabel property position |
| sources/packages/backend/apps/db-migrations/src/sql/Institution/Rollback-rename-regulating-body-ptib-to-ptiru.sql | Rollback script to revert regulating_body from 'ptiru' back to 'ptib' in institutions table |
| sources/packages/backend/apps/db-migrations/src/sql/Institution/Rename-regulating-body-ptib-to-ptiru.sql | Migration script to update regulating_body from 'ptib' to 'ptiru' in institutions table |
| sources/packages/backend/apps/db-migrations/src/sql/EducationPrograms/Rollback-rename-regulatory-body-ptib-to-ptiru.sql | Rollback script to revert regulatory_body from 'ptiru' back to 'ptib' in education_programs table |
| sources/packages/backend/apps/db-migrations/src/sql/EducationPrograms/Rename-regulatory-body-ptib-to-ptiru.sql | Migration script to update regulatory_body from 'ptib' to 'ptiru' in education_programs table |
| sources/packages/backend/apps/db-migrations/src/migrations/1769465086815-UpdateEducationProgramRegulatoryBody.ts | TypeScript migration class to execute the education program regulatory body update |
| sources/packages/backend/apps/db-migrations/src/migrations/1769465037191-UpdateInstitutionRegulatingBody.ts | TypeScript migration class to execute the institution regulating body update |
...ages/backend/apps/db-migrations/src/sql/Institution/Rename-regulating-body-ptib-to-ptiru.sql
Outdated
Show resolved
Hide resolved
...end/apps/db-migrations/src/sql/Institution/Rollback-rename-regulating-body-ptib-to-ptiru.sql
Outdated
Show resolved
Hide resolved
...ackend/apps/db-migrations/src/sql/EducationPrograms/Rename-regulatory-body-ptib-to-ptiru.sql
Outdated
Show resolved
Hide resolved
...ps/db-migrations/src/sql/EducationPrograms/Rollback-rename-regulatory-body-ptib-to-ptiru.sql
Outdated
Show resolved
Hide resolved
|
| "validate": { | ||
| "required": true | ||
| }, | ||
| "validateWhenHidden": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added on save. If there's any risk to this change I can remove. This does seem to be standard in forms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Forms that are not updated frequently may have these changes. It usually reflects the default value of the property.
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good 👍
| "validate": { | ||
| "required": true | ||
| }, | ||
| "validateWhenHidden": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Forms that are not updated frequently may have these changes. It usually reflects the default value of the property.



Overview
Screenshots
Ministry
View Institution Profile
Edit Institution Profile
Create Institution
Institution
Create/Edit Program
Migration Rollback