Skip to content

#4561 - Ministry Dashboard Pending Program Queue#5688

Merged
tiago-graf merged 14 commits intomainfrom
feature/#4561-pending-programs-queue
Feb 3, 2026
Merged

#4561 - Ministry Dashboard Pending Program Queue#5688
tiago-graf merged 14 commits intomainfrom
feature/#4561-pending-programs-queue

Conversation

@tiago-graf
Copy link
Copy Markdown
Collaborator

@tiago-graf tiago-graf commented Jan 29, 2026

Summary

Adds a new view to the Ministry portal to list all programs in pending status.

Frontend Changes

  • Adds new view for pending programs.
  • Update left bar menu to include link to programs queue.
  • Update pending offerings view to remove "status" column.

Backend Changes

  • Update education program service class to add new pending programs method.
  • Update ministry education program controller to add new pending programs endpoint.

E2E Tests

  • Adds new E2E tests for the new pending programs endpoint
image

@tiago-graf tiago-graf self-assigned this Jan 29, 2026
@tiago-graf tiago-graf added Ministry Ministry Features E2E/Unit tests Web portal Backend Used by the dependabot pull requests to identify PRs related to the backend. labels Jan 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Ministry dashboard view to display all programs in pending status, providing similar functionality to the existing pending offerings view. The implementation includes comprehensive backend support, frontend UI, and thorough e2e test coverage.

Changes:

  • New backend endpoint (GET /aest/education-program/pending) with pagination, sorting, and search capabilities for pending programs
  • New Vue component (ViewPendingPrograms.vue) displaying pending programs in a data table with institution details
  • Updated sidebar navigation to include link to the new programs queue view
  • Removed status column from pending offerings view for consistency

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
ViewPendingPrograms.vue New AEST view component for displaying pending programs with search and pagination
ViewPendingOfferings.vue Removed status column and StatusChipOffering component from pending offerings view
DataTableContract.ts Added PendingProgramsHeaders definition and updated PendingOfferingsHeaders
AppRoutes.ts Added PendingPrograms route constant
EducationProgram.dto.ts (frontend) Added EducationProgramPendingAPIOutDTO interface
EducationProgramApi.ts Added getPendingPrograms API client method
EducationProgramService.ts (frontend) Added getPendingPrograms service method
AESTRoutes.ts Added route configuration for ViewPendingPrograms component
RouteConstants.ts Added PENDING_PROGRAMS route constant
AESTHomeSideBar.vue Added "Programs" menu item under Institution requests
education-program.ts (factory) Enhanced factory to support name and programStatus in initialValues
education-program.service.ts Added getPendingPrograms method and addProgramsSort helper
education-program.service.models.ts Added PendingEducationProgram model class
pagination.dto.ts Added PendingProgramsPaginationOptionsAPIInDTO with sortField validation
education-program.dto.ts (backend) Added EducationProgramPendingAPIOutDTO class
education-program.aest.controller.ts Added getPendingPrograms endpoint handler
education-program.aest.controller.getPendingPrograms.e2e-spec.ts Comprehensive e2e tests covering pagination, sorting, filtering, and inactive programs

Comment thread sources/packages/web/src/services/http/EducationProgramApi.ts Outdated
Comment thread sources/packages/web/src/services/EducationProgramService.ts Outdated
Comment thread sources/packages/web/src/services/http/EducationProgramApi.ts
Comment thread sources/packages/web/src/services/EducationProgramService.ts
tiago-graf and others added 2 commits January 30, 2026 14:39
@tiago-graf tiago-graf marked this pull request as ready for review January 30, 2026 22:43
@andrewsignori-aot andrewsignori-aot self-requested a review January 30, 2026 22:52
Comment thread sources/packages/web/src/views/aest/institution/ViewPendingPrograms.vue Outdated
Copy link
Copy Markdown
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, please take a look at the remaining comments.

<template #[`item.offeringDelivered`]="{ item }">
{{ capitalizeFirstWord(item.offeringDelivered) }}
</template>
<template #[`item.offeringStatus`]="{ item }">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I know we talked about this change but I don't recall deciding to go forward with it. If we do, then we should confirm with the business.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, AC is being added to the ticket

Copy link
Copy Markdown
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for making the changes, looks good 👍

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 3, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.15% ( 4321 / 21439 )
Methods: 9.67% ( 253 / 2615 )
Lines: 24.32% ( 3710 / 15254 )
Branches: 10.03% ( 358 / 3570 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 75.41% ( 1055 / 1399 )
Methods: 79.31% ( 115 / 145 )
Lines: 78.79% ( 769 / 976 )
Branches: 61.51% ( 171 / 278 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.68% ( 1616 / 1886 )
Methods: 85% ( 187 / 220 )
Lines: 88.64% ( 1287 / 1452 )
Branches: 66.36% ( 142 / 214 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

E2E SIMS API Coverage Report

Totals Coverage
Statements: 77.25% ( 8860 / 11469 )
Methods: 76.76% ( 1047 / 1364 )
Lines: 81.29% ( 6429 / 7909 )
Branches: 63.02% ( 1384 / 2196 )

@tiago-graf tiago-graf added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 9625cd2 Feb 3, 2026
14 checks passed
@tiago-graf tiago-graf deleted the feature/#4561-pending-programs-queue branch February 3, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Used by the dependabot pull requests to identify PRs related to the backend. E2E/Unit tests Ministry Ministry Features Web portal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants