#5569 - Fix defect when viewing empty assessment#5763
Conversation
weskubo-cgi
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes a UI blank-screen scenario in the student application “Assessment Award” details flow by ensuring the “no assessment data” state is detectable (instead of being masked by an empty-object default).
Changes:
- Removed the
{}default forassessmentAwardDataso falsy checks (e.g., toggle/empty-state rendering) work correctly.
E2E SIMS API Coverage Report
|
| @@ -53,7 +53,6 @@ export default defineComponent({ | |||
| assessmentAwardData: { | |||
| type: Object as PropType<AwardDetailsAPIOutDTO>, | |||
| required: true, | |||
There was a problem hiding this comment.
We can follow the copilot suggestion and add loading like we do with some other components. This will ensure that till the time the assessmentAwardData is fulfilled with the API call, it will show loading for a few fraction of seconds / seconds.
There was a problem hiding this comment.
Thanks for the suggestion. I ended up going with the simplest approach.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
|
404 is now handled gracefully. In the future, the user shouldn't be able to navigate to the screen in this scenario (unless by direct url navigation). 
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Thanks for taking care of the bug. Looks good 👍
Overview
Fixed issue where clicking View when no assessment has been created shows a blank screen. Recent update to toggled logic did not take into account that there is a prop default of
{}. Changed default to undefined so existing logic works as expected. Note, there will be a future fix to disable or hide the View button in this scenario.