#5764 - Legacy Withdraw Restriction Conditions (Cherry Pick to Main)#5769
Merged
CarlyCotton merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
- Updated condition for the `withdrawal_active_flag` to `N` or `NULL` on the DB. Please note, from the file, the value will be a white space that will be imported as `null`, as it is today. - Found an issue when a student with two applications that meet the conditions for a WTHD will generate two active student restrictions when only one should be added. - The added `DISTINCT` caused an SQL error if the parameters in the query were not cast to their types. ## E2E Tests Adapted an existing E2E test to ensure two WTHD will not be added to the same student, and the `withdrawal_active_flag` will be considered as an `N` or ` ` (white space). Queue processor for sfas-integration, √ Should import one active WTHD restrictions and ignore three other SFAS applications for withdrawal import when the SFAS applications have different withdrawal data for withdrawal_date, withdrawal_reason, and withdrawal_active_flag considering withdrawal_active_flag as 'N', and multiple WTHD restrictions must be imported as a single active one. √ Should import one active WTHD restrictions and ignore three other SFAS applications for withdrawal import when the SFAS applications have different withdrawal data for withdrawal_date, withdrawal_reason, and withdrawal_active_flag considering withdrawal_active_flag as 'white space', and multiple WTHD restrictions must be imported as a single active one. ### Data setup for the above scenarios <img width="679" height="142" alt="image" src="https://github.com/user-attachments/assets/6d43cd4d-6a17-409e-8b98-af6d602166d6" /> <img width="683" height="142" alt="image" src="https://github.com/user-attachments/assets/3f5a09fc-30aa-478c-a439-2c9f401e2520" />
CarlyCotton
added
the
Branch Sync-up
|
CarlyCotton
changed the title
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
CarlyCotton
deleted the
cherry-pick/#5764-Legacy-Withdraw-Restriction-Conditions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing the changes from PR #5765 into main.