Skip to content

#5718 - Appeal Conversion - Exceptional Expense#5833

Merged
CarlyCotton merged 4 commits intomainfrom
feature/#5718-appeal-conversion-remove-exceptions-exceptional
Mar 4, 2026
Merged

#5718 - Appeal Conversion - Exceptional Expense#5833
CarlyCotton merged 4 commits intomainfrom
feature/#5718-appeal-conversion-remove-exceptions-exceptional

Conversation

@CarlyCotton
Copy link
Copy Markdown
Collaborator

@CarlyCotton CarlyCotton commented Mar 2, 2026

Form

  • Removed the exceptional expense exception from 26/27 FT form

Camunda

  • Added eligibility into gateway
  • Updated the calculation in the assessment
  • Added eligibility criteria into assessment (all student eligible for it)

Tests

  • Added one exceptional expense appeal test to 26/27 FT
  • Added non-educational cost tests focusing on the total including all of the values that are needed and not what the values are.

@CarlyCotton CarlyCotton self-assigned this Mar 2, 2026
@CarlyCotton CarlyCotton added Form.io Form IO definitions changed. Camunda Worflow Involves camunda workflow changes labels Mar 2, 2026
@CarlyCotton CarlyCotton marked this pull request as draft March 2, 2026 23:11
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.29% ( 4522 / 22291 )
Methods: 9.69% ( 262 / 2703 )
Lines: 24.54% ( 3874 / 15788 )
Branches: 10.16% ( 386 / 3800 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 75.53% ( 1062 / 1406 )
Methods: 79.45% ( 116 / 146 )
Lines: 78.88% ( 773 / 980 )
Branches: 61.79% ( 173 / 280 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 85.68% ( 1616 / 1886 )
Methods: 85% ( 187 / 220 )
Lines: 88.64% ( 1287 / 1452 )
Branches: 66.36% ( 142 / 214 )

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

E2E SIMS API Coverage Report

Totals Coverage
Statements: 76.27% ( 9387 / 12308 )
Methods: 74.88% ( 1082 / 1445 )
Lines: 80.69% ( 6805 / 8433 )
Branches: 61.73% ( 1500 / 2430 )

@CarlyCotton CarlyCotton marked this pull request as ready for review March 3, 2026 16:17
@tiago-graf tiago-graf self-requested a review March 3, 2026 17:04
@andrewsignori-aot andrewsignori-aot self-requested a review March 3, 2026 19:26
);
});

it("Should calculate the exceptional expense amount based on the appeal amount submitted.", async () => {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, try to keep the Should/When pattern.

Copy link
Copy Markdown
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and great E2E tests, looks good 👍

Copy link
Copy Markdown
Collaborator

@tiago-graf tiago-graf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlyCotton CarlyCotton added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit c9b6d20 Mar 4, 2026
22 checks passed
@CarlyCotton CarlyCotton deleted the feature/#5718-appeal-conversion-remove-exceptions-exceptional branch March 4, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Camunda Worflow Involves camunda workflow changes E2E/Unit tests Form.io Form IO definitions changed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants