#5739 - Add institution fields to assessment consolidated data#5864
#5739 - Add institution fields to assessment consolidated data#5864tiago-graf merged 14 commits intomainfrom
Conversation
tiago-graf
added
Camunda Worflow
There was a problem hiding this comment.
Pull request overview
This PR adds four new institution-level fields (country, province, classification, organizationStatus) to the assessment consolidated data pipeline. These fields are fetched from the database, included in the worker output DTO, mapped through BPMN workflow headers, and made available for assessment calculations in the Camunda workflow.
Changes:
- Extends the database query, worker DTO, and controller mapping to include
institutionCountry,institutionProvince,institutionClassification, andinstitutionOrganizationStatusfrom theInstitutionentity. - Adds corresponding BPMN header mappings in the
load-assessment-consolidated-data.bpmnworkflow definition to expose these fields as workflow variables. - Updates the workflow test model interface and test factories with the new fields for both full-time and part-time assessment consolidated data.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
sources/packages/backend/apps/workers/src/services/student-assessment/student-assessment.service.ts |
Adds 4 new institution columns to the SQL select query for assessment data retrieval. |
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.dto.ts |
Adds 4 new optional fields to ApplicationInstitutionJobOutDTO. |
sources/packages/backend/apps/workers/src/controllers/assessment/assessment.controller.ts |
Maps the 4 new institution entity fields to the DTO in transformToAssessmentDTO. |
sources/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn |
Adds 4 new BPMN task headers to extract institution fields via JSONata expressions. |
sources/packages/backend/workflow/test/models/assessment.model.ts |
Adds 4 new optional fields to the AssessmentConsolidatedData test interface. |
sources/packages/backend/workflow/test/test-utils/factories/assessment-consolidated-data.ts |
Sets default values for the new fields in full-time, part-time, and default factory functions. |
| "test:watch": "jest --watch --config ./jest-unit-tests.json", | ||
| "test:cov": "cross-env ENVIRONMENT=test jest --coverage --forceExit --config ./jest-unit-tests.json", | ||
| "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand --config ./jest-unit-tests.json", | ||
| "test:e2e:all:local": "cross-env ENVIRONMENT=test TZ=UTC jest --config ./jest-e2e.json --forceExit", |
There was a problem hiding this comment.
Used by the test explorer to load the test definitions (this will show all e2e tests under the backend folder)
There was a problem hiding this comment.
If this is to be added at this level, the more specific ones must be updated to avoid repetition.
There was a problem hiding this comment.
Did some refactoring to use a preset test file so we we avoid some duplicated configs, renamed the files as well
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Nice work, one comment only about the non-related ticket change.
weskubo-cgi
left a comment
weskubo-cgi
left a comment
There was a problem hiding this comment.
Changes look good. No additional comments.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
left a comment
andrewsignori-aot
left a comment
There was a problem hiding this comment.
Thanks for doing the changes, looks good 👍
Summary
Adds additional institution fields to the assessment consolidated data