#5816 - Appeals/Forms history view, data connection, and institution view - Fix Institution Notes#5893
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the Form Submission API mapping that prevented institutions from seeing the final decision note description after a submission was completed, while still keeping decision details hidden for pending submissions by default.
Changes:
- Decouples
includeBasicDecisionDetailsfromkeepPendingDecisionsWhilePendingFormSubmissionso institutions can receive decision note details on completed submissions. - Updates decision mapping to restrict both status and note details only when the submission is pending and restrictions are enabled.
You can also share your feedback on Copilot code review. Take the survey.
weskubo-cgi
left a comment
weskubo-cgi
left a comment
There was a problem hiding this comment.
Looks good. Just two non-blocking comments.
| : submissionItem.currentDecision?.decisionStatus; | ||
| // Default to Pending if no decision exists. | ||
| submissionStatus === FormSubmissionStatus.Pending; | ||
| // Defined the status. |
There was a problem hiding this comment.
"Define the status." might read better. Same comment applies below.
| includeBasicDecisionDetails = | ||
| options?.includeBasicDecisionDetails ?? false; | ||
| } | ||
| const includeBasicDecisionDetails = |
There was a problem hiding this comment.
I noticed that form-submission.aest.controller.ts passes in includedBasicDecisionDetails : false (which is the default) whereas other controllers which require false just omit it.
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
deleted the
fix/#5816-notes-not-displayed-for-institutions
branch
Fix the error introduced in the last refactor prior to merging the PR that prevents the final note decision from being displayed for institutions.