#5878 - Student Forms e2e Tests - completeFormSubmission by andrewsignori-aot · Pull Request #5970 · bcgov/SIMS

andrewsignori-aot · 2026-03-27T22:50:18Z

PR Goal

Add some level of API endpoints E2E tests to all new endpoints introduced during the new forms implementation. At least one scenario for each endpoint must be present, and more scenarios can be added if time allows it. Suggestions for scenarios not covered are appreciated, but will be taken care of based on criticality and time available 😉

Ministry - completeFormSubmission

Should complete a student appeal, create an appeal assessment, and generate a notification when all items have decisions and the user has approval authorization.
Should complete a student form submission, update the modified independent status to Approved, and generate a notification when the user completes the form submission and the user has approval authorization.
Should complete a student form submission, update the modified independent status to Declined and generate a notification when the user completes the form submission and the user has approval authorization.
Should throw an unprocessable entity error when attempting to complete a student appeal but some items were updated.
Should throw an unprocessable entity error when attempting to complete a student appeal but the application was edited.
Should throw an unprocessable entity error when attempting to complete a student form but an item decision is pending.
Should throw a forbidden error when attempting to complete the form of category Student appeal but the user lacks the necessary roles.
Should throw a forbidden error when attempting to complete the form of category Student form but the user lacks the necessary roles.
Should throw a forbidden error when attempting to complete the form but the user does not have access to the endpoint.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

tiago-graf · 2026-03-28T23:42:51Z

+      creator: ministryAuditUser,
+      messagePayload: {
+        email_address: student.user.email,
+        template_id: "fed6b26e-d1f2-4a8c-bfe5-5cb66c00458b",


we have a constant for this value: GC_NOTIFY_TEMPLATE_IDS

tiago-graf · 2026-03-28T23:45:10Z

+          creator: ministryAuditUser,
+          messagePayload: {
+            email_address: student.user.email,
+            template_id: "fed6b26e-d1f2-4a8c-bfe5-5cb66c00458b",


tiago-graf

Looks good, just 2 minor comments

dheepak-aot · 2026-03-30T17:56:41Z

+        email_address: student.user.email,
+        template_id: "fed6b26e-d1f2-4a8c-bfe5-5cb66c00458b",
+        personalisation: {
+          givenNames: student.user.firstName,


Does the student template not have application number?

Not right now.

sonarqubecloud · 2026-03-30T19:11:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-30T19:11:50Z

Backend Unit Tests Coverage Report

Totals
Statements:	20.1% ( 4579 / 22781 )
Methods:	9.45% ( 262 / 2773 )
Lines:	24.48% ( 3931 / 16059 )
Branches:	9.77% ( 386 / 3949 )

github-actions · 2026-03-30T19:12:16Z

E2E Workflow Workers Coverage Report

Totals
Statements:	48.27% ( 2713 / 5620 )
Methods:	38.26% ( 285 / 745 )
Lines:	55.14% ( 2050 / 3718 )
Branches:	32.67% ( 378 / 1157 )

github-actions · 2026-03-30T19:15:02Z

E2E Queue Consumers Coverage Report

Totals
Statements:	79.33% ( 9156 / 11542 )
Methods:	78.47% ( 1181 / 1505 )
Lines:	82.66% ( 6882 / 8326 )
Branches:	63.88% ( 1093 / 1711 )

github-actions · 2026-03-30T19:17:30Z

E2E SIMS API Coverage Report

Totals
Statements:	67.7% ( 13449 / 19867 )
Methods:	65.09% ( 1600 / 2458 )
Lines:	70.97% ( 9695 / 13661 )
Branches:	57.47% ( 2154 / 3748 )

dheepak-aot

Thanks for making the changes. Looks good 👍

completeFormSubmission with modified independent

7c215fe

andrewsignori-aot self-assigned this Mar 27, 2026

andrewsignori-aot added Ministry Ministry Features E2E/Unit tests labels Mar 27, 2026

andrewsignori-aot requested a review from Copilot March 27, 2026 22:50

Copilot started reviewing on behalf of andrewsignori-aot March 27, 2026 22:50 View session

This comment was marked as outdated.

Sign in to view

andrewsignori-aot added 2 commits March 27, 2026 16:01

Copilot and other fixes

17c1373

Minor fixes

e053f80

andrewsignori-aot requested a review from Copilot March 27, 2026 23:23

Copilot started reviewing on behalf of andrewsignori-aot March 27, 2026 23:23 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

andrewsignori-aot added 4 commits March 27, 2026 16:39

Minor test desc change

81be66c

Added order by

9d88c40

Additional E2E tests for authorization

8cf02c2

Minor E2E setup fix

cff998b

andrewsignori-aot marked this pull request as ready for review March 28, 2026 00:21

tiago-graf reviewed Mar 28, 2026

View reviewed changes

tiago-graf approved these changes Mar 28, 2026

View reviewed changes

dheepak-aot reviewed Mar 30, 2026

View reviewed changes

Comment thread ...rm-submission/_tests_/e2e/form-submission.aest.controller.completeFormSubmission.e2e-spec.ts Outdated

dheepak-aot reviewed Mar 30, 2026

View reviewed changes

Comment thread ...rm-submission/_tests_/e2e/form-submission.aest.controller.completeFormSubmission.e2e-spec.ts

dheepak-aot reviewed Mar 30, 2026

View reviewed changes

Comment thread ...rm-submission/_tests_/e2e/form-submission.aest.controller.completeFormSubmission.e2e-spec.ts Outdated

dheepak-aot reviewed Mar 30, 2026

View reviewed changes

Comment thread ...rm-submission/_tests_/e2e/form-submission.aest.controller.completeFormSubmission.e2e-spec.ts

andrewsignori-aot added 2 commits March 30, 2026 11:50

Consumed template IDs from GC_NOTIFY_TEMPLATE_IDS

5f73255

PR comments

0faf7b9

dheepak-aot approved these changes Mar 30, 2026

View reviewed changes

andrewsignori-aot added this pull request to the merge queue Mar 30, 2026

Merged via the queue into main with commit 341e2f8 Mar 30, 2026
22 checks passed

andrewsignori-aot deleted the feature/#5878-forms-e2e-tests-part-6 branch March 30, 2026 20:51

andrewsignori-aot temporarily deployed to DEV March 30, 2026 20:56 — with GitHub Actions Inactive

andrewsignori-aot temporarily deployed to DEV March 30, 2026 20:59 — with GitHub Actions Inactive

Conversation

andrewsignori-aot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Goal

Ministry - completeFormSubmission

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tiago-graf Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

andrewsignori-aot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

tiago-graf Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

andrewsignori-aot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

tiago-graf left a comment

Choose a reason for hiding this comment

Uh oh!

dheepak-aot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

andrewsignori-aot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 30, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Mar 30, 2026

Backend Unit Tests Coverage Report

Uh oh!

github-actions Bot commented Mar 30, 2026

E2E Workflow Workers Coverage Report

Uh oh!

github-actions Bot commented Mar 30, 2026

E2E Queue Consumers Coverage Report

Uh oh!

github-actions Bot commented Mar 30, 2026

E2E SIMS API Coverage Report

Uh oh!

dheepak-aot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andrewsignori-aot commented Mar 27, 2026 •

edited

Loading