Skip to content

feat: pass document dates in applications & registrations responses#1016

Merged
JazzarKarim merged 2 commits intobcgov:mainfrom
JazzarKarim:32298-pass-documents-date
Feb 4, 2026
Merged

feat: pass document dates in applications & registrations responses#1016
JazzarKarim merged 2 commits intobcgov:mainfrom
JazzarKarim:32298-pass-documents-date

Conversation

@JazzarKarim
Copy link
Collaborator

@JazzarKarim JazzarKarim commented Feb 3, 2026

Issue:

Description of changes:
Registrations endpoint, before:
before reg endpoint

After:
after reg endpoint

Applications endpoint, before:
image

After:
image

The fix for registrations was very simple, just grab the created date from the documents table if addedOn is not found.

The fix for applications was trickier though as we don't store documents in the documents table if there is no registration yet. I created a function that grabs the date from GCP storage.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@dimak1
Copy link
Collaborator

dimak1 commented Feb 3, 2026

@JazzarKarim what about uploadDate, should it be also in the picture somewhere?

@JazzarKarim
Copy link
Collaborator Author

@JazzarKarim what about uploadDate, should it be also in the picture somewhere?

No, the uploadDate is just an internal field we'll use sometimes to fill the addedOn field. For the UI, the addedOn field is what we'll be using (you can ignore that uploadDate field).

@dimak1
Copy link
Collaborator

dimak1 commented Feb 4, 2026

@JazzarKarim during document upload during application, we do use uploadDate in BaseUploadAdditionalDocuments.

Copy link
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@JazzarKarim JazzarKarim merged commit 8b9c3b2 into bcgov:main Feb 4, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants