Skip to content

fix(security): Fixing upstream security issue of main dependency. Add a lot of tests#1088

Merged
thorwolpert merged 2 commits intobcgov:mainfrom
thorwolpert:31719-fix-security-issue
Mar 11, 2026
Merged

fix(security): Fixing upstream security issue of main dependency. Add a lot of tests#1088
thorwolpert merged 2 commits intobcgov:mainfrom
thorwolpert:31719-fix-security-issue

Conversation

@thorwolpert
Copy link
Collaborator

Issue: bcgov/entity#31719

Description of changes:

  • fix security dependencies
  • add tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@thorwolpert
Copy link
Collaborator Author

Not going to touch the Sonar stuff, using random in tests is not a production runtime security risk.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@thorwolpert thorwolpert self-assigned this Mar 11, 2026
@thorwolpert thorwolpert requested a review from JazzarKarim March 11, 2026 14:42
Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@thorwolpert thorwolpert merged commit 9a16f77 into bcgov:main Mar 11, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants