Conversation
|
/gcbrun |
|
Temporary Url for review: https://strr-examiner-dev--pr-1116-eymzof28.web.app |
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1116-z15uxkk2.web.app |
|
Temporary Url for review: https://strr-platform-dev--pr-1116-8trwhk78.web.app |
|
Temporary Url for review: https://strr-hosts-dev--pr-1116-gbihlvsh.web.app |
|
Assigned the dev team for visibility. |
JazzarKarim
left a comment
JazzarKarim
left a comment
There was a problem hiding this comment.
LGTM but please wait for extra review from the other devs before merging. Thanks.
panish16
force-pushed
the
32835-nodejs-new
branch
2 times, most recently
from
00341df to
fba62c5
Compare
|
/gcbrun |
|
Temporary Url for review: https://strr-examiner-dev--pr-1116-eymzof28.web.app |
|
Temporary Url for review: https://strr-hosts-dev--pr-1116-gbihlvsh.web.app |
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1116-z15uxkk2.web.app |
|
Temporary Url for review: https://strr-platform-dev--pr-1116-8trwhk78.web.app |
|
@panish16 please do not merge it yet, we'll merge by end of the week, as we have prod deployment(s). Thanks |
|
Couple of things. Switch to draft if you want to block merging. |
|
|
@panish16 thanks for resolving the conflicts. Good to merge on my end. |
6 participants
Issue: https://app.zenhub.com/workspaces/sre-team-board-654d163c6817d80016102d9a/issues/gh/bcgov/entity/32835
Description of changes:
Update engines field in package.json to require Node.js >= 24.
Update node_version from 22 to 24
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License