Skip to content

test: implement common pytests in renewal-reminders#1464

Merged
thorwolpert merged 1 commit intobcgov:mainfrom
thorwolpert:1130a-implement_pytests-renewal-reminders
Mar 30, 2026
Merged

test: implement common pytests in renewal-reminders#1464
thorwolpert merged 1 commit intobcgov:mainfrom
thorwolpert:1130a-implement_pytests-renewal-reminders

Conversation

@thorwolpert
Copy link
Copy Markdown
Collaborator

@thorwolpert thorwolpert commented Mar 30, 2026

Issue: #1130 #1458

Description of changes:

  • implement common pytest
  • Update Dockerfile to not load non-prod libraries
  • additional tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
23.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@thorwolpert
Copy link
Copy Markdown
Collaborator Author

SC Issues

  • csrf warning doesn't apply to jobs
  • using random in tests is fine

@thorwolpert thorwolpert self-assigned this Mar 30, 2026
@thorwolpert thorwolpert requested a review from JazzarKarim March 30, 2026 07:17
@thorwolpert thorwolpert changed the title test: implement common pytests inrenewal-reminders test: implement common pytests in renewal-reminders Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thorwolpert thorwolpert merged commit 51aabf5 into bcgov:main Mar 30, 2026
11 of 12 checks passed
@dimak1 dimak1 mentioned this pull request Apr 8, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants