Skip to content

feat: registrations that have been cancelled can no longer be renewed#1470

Merged
JazzarKarim merged 4 commits intobcgov:mainfrom
JazzarKarim:1138-no-renewals-for-cancelled
Mar 30, 2026
Merged

feat: registrations that have been cancelled can no longer be renewed#1470
JazzarKarim merged 4 commits intobcgov:mainfrom
JazzarKarim:1138-no-renewals-for-cancelled

Conversation

@JazzarKarim
Copy link
Copy Markdown
Collaborator

@JazzarKarim JazzarKarim commented Mar 30, 2026

Issue:

Description of changes:

  • Registrations that have been cancelled can no longer be renewed
  • Registrations that are cancelled will no longer transition to expired
  • Added extra guards in the API to prevent edge case errors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@JazzarKarim JazzarKarim self-assigned this Mar 30, 2026
@sonarqubecloud
Copy link
Copy Markdown

@JazzarKarim JazzarKarim marked this pull request as ready for review March 30, 2026 21:36
Copy link
Copy Markdown
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does it to me.

@JazzarKarim JazzarKarim merged commit 1739e79 into bcgov:main Mar 30, 2026
19 of 22 checks passed
@dimak1 dimak1 mentioned this pull request Apr 8, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants