feat(ui+api): logic changes to substatus filters & renewal badge#1506
Merged
JazzarKarim merged 5 commits intobcgov:mainfrom Apr 13, 2026
Merged
feat(ui+api): logic changes to substatus filters & renewal badge#1506JazzarKarim merged 5 commits intobcgov:mainfrom
JazzarKarim merged 5 commits intobcgov:mainfrom
Conversation
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1506-cjnz9264.web.app |
1 similar comment
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1506-cjnz9264.web.app |
dimak1
reviewed
Apr 8, 2026
Collaborator
dimak1
left a comment
dimak1
left a comment
There was a problem hiding this comment.
Nice work, looks good, just few comments to clarify.
JazzarKarim
force-pushed
the
1118-replace-substatus-filters
branch
from
c7826b0 to
d55d6bc
Compare
Collaborator
Author
|
As per new requirements:
Review:
Badge: same as Review Renew |
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1506-cjnz9264.web.app |
|
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1506-cjnz9264.web.app |
thorwolpert
approved these changes
Apr 13, 2026
JazzarKarim
changed the title
JazzarKarim
changed the title
JazzarKarim
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
Here are a list of changes of what this PR does:
I tested my changes in both old and new dashboard. They both look good from my perspective. Old dashboard works the exact same way as before. New one has that updated logic.
Here's an example of stuff that won't show anymore in Review:
Previously, something like this used to show:
Now, it doesn't. Reason is because it was provisionally approved and there is a decider.
For review renew, something like this won't show anymore:
Reason being, it's a provisionally approved renewal with a decider.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License