feat(ui): removed registered office/attorney fields from strata hotel#1518
feat(ui): removed registered office/attorney fields from strata hotel#1518JazzarKarim merged 5 commits intobcgov:mainfrom
Conversation
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1518-wrldhcmo.web.app |
3 similar comments
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1518-wrldhcmo.web.app |
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1518-wrldhcmo.web.app |
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1518-wrldhcmo.web.app |
| homeJurisdiction: bus.homeJurisdiction, | ||
| businessNumber: bus.businessNumber, | ||
| mailingAddress: formatAddress(bus.mailingAddress), | ||
| registeredOfficeOrAttorneyForServiceDetails: { |
There was a problem hiding this comment.
if this field is only used in select UIs, then can we not make this field optional instead of passing emtpy data?
There was a problem hiding this comment.
Good point. Making it optional would be nice/better but there's a caveat. We would need to change that ApiBusinessDetails interface which is in the base layer. I'd rather not go there as that interface is used in a ton of other places so we'll need to be careful with that.
dimak1
left a comment
dimak1
left a comment
There was a problem hiding this comment.
Just few comments around cleanup. Related content also needs to be removed at some point.
|
|
||
| const getBusinessSchema = () => { | ||
| return getBaseBusinessSchema().omit({ | ||
| hasRegOffAtt: true, |
There was a problem hiding this comment.
Are you omitting these for now, with intention to cleanup later?
There was a problem hiding this comment.
I'm omitting here to avoid touching shared API types for now. I'm thinking a bigger cleanup for these shared schemas can be done later in a techdebt ticket.
JazzarKarim
force-pushed
the
1082-remove-fields-strata
branch
from
b1c3aa3 to
2a3d357
Compare
|
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1518-wrldhcmo.web.app |
|
@dimak1 @jimmypalelil Let me know if this looks good to you, thanks! |
|
Looks good to me. Just need a new ticket for a more comprehensive tech debt cleanup. Thanks! |
4 participants
Issue:
Description of changes:
Now:
In step 2:
In step 4 (Review page):
Before:
After:
When view the strata hotel:
Before:
After:
We can ignore SC issue as a similar pattern is already used in all of the file...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License