feat(ui): remove confirmation dialogue boxes in examiner's UI#1548
Merged
JazzarKarim merged 5 commits intobcgov:mainfrom Apr 17, 2026
Merged
feat(ui): remove confirmation dialogue boxes in examiner's UI#1548JazzarKarim merged 5 commits intobcgov:mainfrom
JazzarKarim merged 5 commits intobcgov:mainfrom
Conversation
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1548-k8pae9ik.web.app |
1 similar comment
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1548-k8pae9ik.web.app |
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1548-k8pae9ik.web.app |
|
|
||
| const approveRegistrationAction = () => { | ||
| openConfirmActionModal( | ||
| t('modal.approveRegistration.title'), |
Collaborator
There was a problem hiding this comment.
should the i8n strings be cleaned up?
Collaborator
Author
There was a problem hiding this comment.
Great catch Jimmy. I cleaned those up. Thanks!
dimak1
reviewed
Apr 17, 2026
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1548-k8pae9ik.web.app |
9 tasks
|
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1548-k8pae9ik.web.app |
dimak1
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License