Skip to content

test(strr-backfiller): add unit and integration tests with full coverage#1550

Merged
jimmypalelil merged 4 commits intobcgov:mainfrom
jimmypalelil:1131-strr-backfiller-pytests
Apr 20, 2026
Merged

test(strr-backfiller): add unit and integration tests with full coverage#1550
jimmypalelil merged 4 commits intobcgov:mainfrom
jimmypalelil:1131-strr-backfiller-pytests

Conversation

@jimmypalelil
Copy link
Copy Markdown
Collaborator

@jimmypalelil jimmypalelil commented Apr 17, 2026

Issue:

#1131

Description of changes:

  • unit and integation tests
  • some changes to common fixtures (see inline PR comments)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@jimmypalelil jimmypalelil force-pushed the 1131-strr-backfiller-pytests branch from 19558c7 to 9c55ac6 Compare April 17, 2026 20:52
@jimmypalelil jimmypalelil force-pushed the 1131-strr-backfiller-pytests branch 2 times, most recently from d4c363a to 2ea4e9c Compare April 17, 2026 23:02
@jimmypalelil jimmypalelil force-pushed the 1131-strr-backfiller-pytests branch from 2ea4e9c to eb07a0d Compare April 17, 2026 23:07
@jimmypalelil jimmypalelil force-pushed the 1131-strr-backfiller-pytests branch from 23a3fc2 to 309d654 Compare April 17, 2026 23:36
@sonarqubecloud
Copy link
Copy Markdown

&& poetry run pip install -U pip \
&& poetry install \
$(if [ -z ${APP_ENV+x} ] | [ "$APP_ENV" = 'production' ]; then echo '--only main'; fi) \
$(if [ -z "$APP_ENV" ] || [ "$APP_ENV" = 'production' ]; then echo '--only main'; fi) \
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the verify-build step was failing because of the dependency on strr-test-utils

from structlog.testing import capture_logs


@pytest.fixture
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted all the common fixtures into utils_fixtrues in strr-test-utils. this was done to fix sonarqube's complaint about duplicated code across the codebase

@jimmypalelil jimmypalelil marked this pull request as ready for review April 17, 2026 23:55
Copy link
Copy Markdown
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmypalelil jimmypalelil merged commit 05ee09c into bcgov:main Apr 20, 2026
31 checks passed
@dimak1 dimak1 mentioned this pull request Apr 23, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants