test(strr-backfiller): add unit and integration tests with full coverage#1550
Merged
jimmypalelil merged 4 commits intobcgov:mainfrom Apr 20, 2026
Merged
Conversation
19558c7 to
9c55ac6
Compare
d4c363a to
2ea4e9c
Compare
2ea4e9c to
eb07a0d
Compare
23a3fc2 to
309d654
Compare
|
jimmypalelil
commented
Apr 17, 2026
| && poetry run pip install -U pip \ | ||
| && poetry install \ | ||
| $(if [ -z ${APP_ENV+x} ] | [ "$APP_ENV" = 'production' ]; then echo '--only main'; fi) \ | ||
| $(if [ -z "$APP_ENV" ] || [ "$APP_ENV" = 'production' ]; then echo '--only main'; fi) \ |
Collaborator
Author
There was a problem hiding this comment.
the verify-build step was failing because of the dependency on strr-test-utils
jimmypalelil
commented
Apr 17, 2026
| from structlog.testing import capture_logs | ||
|
|
||
|
|
||
| @pytest.fixture |
Collaborator
Author
There was a problem hiding this comment.
extracted all the common fixtures into utils_fixtrues in strr-test-utils. this was done to fix sonarqube's complaint about duplicated code across the codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue:
#1131
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License