feat(api): 1525 let examiners update address of expired regs#1560
Merged
JazzarKarim merged 3 commits intobcgov:mainfrom Apr 22, 2026
Merged
feat(api): 1525 let examiners update address of expired regs#1560JazzarKarim merged 3 commits intobcgov:mainfrom
JazzarKarim merged 3 commits intobcgov:mainfrom
Conversation
|
dimak1
approved these changes
Apr 21, 2026
Collaborator
dimak1
left a comment
There was a problem hiding this comment.
Looks good to me. No UI changes? 'Edit' link is always active?
Collaborator
Author
Nope, no UI changes. That Edit link is always active except for when the registration is in the CANCELLED state which makes sense! |
thorwolpert
approved these changes
Apr 22, 2026
Collaborator
thorwolpert
left a comment
There was a problem hiding this comment.
Nice, pretty clear change and the comments helped confirm what I was gleaning from the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue:
Description of changes:
One the registration expires, still allow staff to assign the registration and edit the STR address
Expired registrations:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License