Skip to content

feat(api): 1525 let examiners update address of expired regs#1560

Merged
JazzarKarim merged 3 commits intobcgov:mainfrom
JazzarKarim:1525-update-str-address
Apr 22, 2026
Merged

feat(api): 1525 let examiners update address of expired regs#1560
JazzarKarim merged 3 commits intobcgov:mainfrom
JazzarKarim:1525-update-str-address

Conversation

@JazzarKarim
Copy link
Copy Markdown
Collaborator

@JazzarKarim JazzarKarim commented Apr 21, 2026

Issue:

Description of changes:
One the registration expires, still allow staff to assign the registration and edit the STR address

Expired registrations:

  • Now examiners can unassign, assign them
  • Press the edit button of the address and change the address
image image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@JazzarKarim JazzarKarim self-assigned this Apr 21, 2026
@sonarqubecloud
Copy link
Copy Markdown

@JazzarKarim JazzarKarim marked this pull request as ready for review April 21, 2026 20:36
Copy link
Copy Markdown
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No UI changes? 'Edit' link is always active?

@JazzarKarim JazzarKarim changed the title feat(api): let examiners update address of expired regs feat(api): 1525 let examiners update address of expired regs Apr 21, 2026
@JazzarKarim
Copy link
Copy Markdown
Collaborator Author

Looks good to me. No UI changes? 'Edit' link is always active?

Nope, no UI changes. That Edit link is always active except for when the registration is in the CANCELLED state which makes sense!

@dimak1 dimak1 requested a review from Jacky-Pham April 22, 2026 21:05
Copy link
Copy Markdown
Collaborator

@thorwolpert thorwolpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pretty clear change and the comments helped confirm what I was gleaning from the code.

@JazzarKarim JazzarKarim merged commit 9bcd1c1 into bcgov:main Apr 22, 2026
12 checks passed
@dimak1 dimak1 mentioned this pull request Apr 23, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants