fix(strr-api): add nanoid as a runtime dependency#1568
Merged
Jacky-Pham merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
|
JazzarKarim
reviewed
Apr 22, 2026
jimmypalelil
approved these changes
Apr 22, 2026
JazzarKarim
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nanoidfrom the test dependency group to runtime dependenciespoetry.lockto match the dependency moveWhy
nanoidis imported by runtime application code instrr-api/src/strr_api/models/application.py, so keeping it in the test group can cause the deployed service to fail at startup withModuleNotFoundError.Notes
This is a clean follow-up to #1565 with only the
nanoiddependency change.