Skip to content

API - Assign & Unassign - Allow on all statuses #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaangill025 merged 2 commits into from
Apr 11, 2025
Merged

API - Assign & Unassign - Allow on all statuses #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df2f479
26347 - allow assign & unassign for application of all statuses excep…
shaangill025 Apr 11, 2025
8ba8e6c
26347 - update status list
shaangill025 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion strr-api/src/strr_api/services/application_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,18 @@
Application.Status.ADDITIONAL_INFO_REQUESTED,
]
APPLICATION_UNPAID_STATES = [Application.Status.DRAFT, Application.Status.PAYMENT_DUE]
APPLICATION_ASSIGN_STATES = [Application.Status.FULL_REVIEW, Application.Status.PROVISIONAL_REVIEW]
APPLICATION_ASSIGN_STATES = [
Application.Status.FULL_REVIEW,
Application.Status.PROVISIONAL_REVIEW,
Application.Status.PROVISIONAL,
Application.Status.NOC_PENDING,
Copy link
Copy Markdown
Contributor

@kris-daxiom kris-daxiom Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Payment Due, Paid applications the staff does not have any action and it should not be assigned to them when they cannot act on it

Copy link
Copy Markdown
Contributor Author

@shaangill025 shaangill025 Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As shared in the teams chat, I think current UXA and business understanding is that all applications in the examiner list view should be assignable.

Copy link
Copy Markdown
Contributor Author

@shaangill025 shaangill025 Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Payment due and Paid statuses removed

Application.Status.NOC_EXPIRED,
Application.Status.ADDITIONAL_INFO_REQUESTED,
Application.Status.FULL_REVIEW_APPROVED,
Application.Status.PROVISIONALLY_APPROVED,
Application.Status.AUTO_APPROVED,
Application.Status.DECLINED,
]


class ApplicationService:
Expand Down
3 changes: 3 additions & 0 deletions strr-api/tests/unit/resources/test_registration_applications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,9 @@ def test_assign_and_unassign_application(session, client, jwt):
rv = client.post("/applications", json=json_data, headers=headers)
assert HTTPStatus.OK == rv.status_code
application_number = rv.json.get("header").get("applicationNumber")
application = Application.find_by_application_number(application_number=application_number)
application.status = Application.Status.PAYMENT_DUE
application.save()

staff_headers = create_header(jwt, [STRR_EXAMINER], "Account-Id")
rv = client.put(f"/applications/{application_number}/assign", headers=staff_headers)
Expand Down