feature/AB#28576 - Tag Management Settings

[plavoie-BC]

This pull request implements a Setting Management Interface for Tag Management:

Application and Payment Tags Management:

• Settings Interface:
  • Added a Tag Management Settings UI that combines data from ApplicationTags and PaymentTags into one interface.
  • Added an Edit Modal and Delete Buttons to manage tags of both types.
• Business Logic:
  • Implemented tag sanitization in CreateorUpdateTagsAsync to ensure consistent formatting of tag strings.
  • Added methods in ApplicationTagAppService and PaymentTagAppService for tag management, including tag summary retrieval, renaming, and deletion with validation and error handling.
• Data Models:
  • Introduced TagSummaryCountDto and TagSummaryCount for ApplicationTags and PaymentTags classes to represent tag summaries, including tag name and count. [1] [2]
• Repository Enhancements:
  • Added methods in IApplicationTagsRepository and IPaymentTagRepository and their implementations to support tag summary retrieval and maximum rename length calculation for client-side validation. [1] [2]
• Payment Request Tag Event Handlers:
  • Created DeleteTagHandler and RenameTagHandler to handle tag deletion and renaming events asynchronously and maintain modular separation. [1] [2]
• Permissions and Settings:
  • Defined new permissions for tag management (read, update, delete) under the SettingManagement.Tags namespace. [1] [2]
  • Mapped new permissions as defaults for the team-lead and system-admin roles.

[Copilot]

Pull Request Overview

This pull request adds a consolidated Tag Management Settings interface and implements tag-related business logic for both application tags and payment tags. Key changes include new UI-related mappings and permissions, enhanced tag sanitization and renaming logic in the application and payment services, and the addition of event handlers for tag rename and deletion.

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
GrantManagerApplicationAutoMapperProfile.cs	Added mapping for TagSummaryCount to TagSummaryCountDto.
ApplicationTagsAppService.cs	Introduced tag sanitization, tag summary retrieval, rename and delete methods for application tags, and integrated local event bus notifications.
PaymentTagAppService.cs	Implemented similar tag management features for payment tags along with tag summary, rename, and delete support.
PaymentTagRepository.cs	Added repository methods for tag summary grouping and max rename length calculation.
PermissionDefinitionProvider.cs, UnitySelector.cs, DTOs, and event handlers	Introduced new tag management permissions and supporting types/events.
NotificationsSettingPageContributor.cs and its view	Updated notifications settings with minor ordering improvements.

Comments suppressed due to low confidence (1)

applications/Unity.GrantManager/modules/Unity.Payments/src/Unity.Payments.Application/Events/RenameTagEto.cs:8

• Consider renaming 'originalTagName' (and similarly 'replacementTagName') to 'OriginalTagName' and 'ReplacementTagName' to follow standard C# property naming conventions.

public required string originalTagName { get; set; }

[jimmyPasta]

Thanks Patrick very thrurough