Feature/ab#29006 failed submission notifications #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the intake resync window, enriches the synchronization worker to send summary emails for missing submissions, and adjusts Teams alerts to only fire when there are failures.
- Increased the default lookback from 2 to 4 days in background job settings
- Enhanced
IntakeSyncWorkerto build and send an HTML email when missing submissions are detected - Updated
GetMissingSubmissionsto return both the set of missing IDs and a formatted report, and gated Teams notifications on nonempty results
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/src/Unity.GrantManager.Domain/Settings/GrantManagerSettingDefinitionProvider.cs | Changed IntakeResync_NumDaysToCheck default from "-2" to "-4" |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/Intakes/BackgroundWorkers/IntakeSyncWorker.cs | Injected IEmailNotificationService, added HTML email construction and send logic |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/ApplicationForms/ApplicationFormSycnronizationService.cs | Altered GetMissingSubmissions to return a (HashSet<string>, string) tuple and only post to Teams when there are missing submissions |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application.Contracts/ApplicationForms/IApplicationFormSycnronizationService.cs | Updated interface signature for GetMissingSubmissions to match new tuple return type |
Comments suppressed due to low confidence (1)
applications/Unity.GrantManager/src/Unity.GrantManager.Application/Intakes/BackgroundWorkers/IntakeSyncWorker.cs:83
- Add unit tests to verify that the email notification path is only executed when there are missing submissions and that the generated HTML content matches expectations.
if (sendEmail) {
| @@ -1,9 +1,11 @@ | |||
| using Microsoft.Extensions.Logging; | |||
| using Quartz; | |||
| using System.Net.Http; | |||
There was a problem hiding this comment.
The System.Net.Http import is not used in this file; consider removing it to keep the usings clean.
Suggested change
| using System.Net.Http; |
| } | ||
| } | ||
|
|
||
| emailBodyBuilder.AppendLine("<br> Bests"); |
There was a problem hiding this comment.
[nitpick] The closing greeting "Bests" looks like a typo; consider using "Best regards," or simply "Best,".
Suggested change
| emailBodyBuilder.AppendLine("<br> Bests"); | |
| emailBodyBuilder.AppendLine("<br> Best regards,"); |
jimmyPasta
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added email to already existent intake sync worker, and adjusted teams notification to only send when submissions are missing.