Skip to content

Bugfix/ab#29195 saved views columns issue #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPasta merged 2 commits into from
Jun 27, 2025
Merged

Bugfix/ab#29195 saved views columns issue #1458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f113d04
bugfix/ab#29195 sonarQube fix and clean up code
samsaravillo Jun 27, 2025
e84598b
Merge branch 'dev' into bugfix/ab#29195-saved-views-columns-issue
samsaravillo Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions ...rantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/wwwroot/themes/ux2/table-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function initializeDataTable(options) {
try {
dtApi = new $.fn.dataTable.Api(settings);

if (!dtApi || !dtApi.table().node()) {
if (!dtApi?.table()?.node()) {
throw new Error('Invalid DataTable instance.');
}

Expand Down Expand Up @@ -511,26 +511,6 @@ function toggleFilterRow() {
$(this).popover('toggle');
$('#dtFilterRow').toggleClass('hidden');
}
function updateColvisButtonState($btn, api, colIndex) {
const visible = api.column(colIndex).visible();
$btn.toggleClass('dt-button-active', visible);
}

function syncColvisButtonStates(api) {
const aoColumns = api.settings()[0].aoColumns;

let x = $('.dt-button-collection .dt-button');
let z = $('.dt-button-collection a.dt-button');
$('.dt-button-collection a.dt-button').each(function () {
const $btn = $(this);
const colName = $btn.attr('data-cv-name');

const colIndex = aoColumns.findIndex((col) => col.name === colName);
if (colIndex !== -1) {
updateColvisButtonState($btn, api, colIndex);
}
});
}

function findColumnByTitle(title, dataTable) {
let columnIndex = dataTable
Expand Down