hotfix/AB#29535 - Bulk Approval Bugfix for Missing Approval Fields#1502
Merged
plavoie-BC merged 3 commits intomainfrom Jul 15, 2025
Merged
hotfix/AB#29535 - Bulk Approval Bugfix for Missing Approval Fields#1502plavoie-BC merged 3 commits intomainfrom
plavoie-BC merged 3 commits intomainfrom
Conversation
… update modal inputs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the bulk approval functionality where approval fields were missing during form submission. The fix ensures that RequestedAmount and RecommendedAmount values are properly preserved and transmitted when processing bulk application approvals.
- Adds hidden input fields to preserve disabled form values during submission
- Implements server-side field mapping to ensure data integrity from the database
- Includes IsDirectApproval field mapping for complete approval context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ApproveApplicationsModal.cshtml | Adds hidden input fields to preserve RequestedAmount and RecommendedAmount values during form submission |
| BulkApprovalsAppService.cs | Maps RequestedAmount, RecommendedAmount, and IsDirectApproval fields directly from database to ensure data consistency |
....GrantManager/src/Unity.GrantManager.Web/Pages/BulkApprovals/ApproveApplicationsModal.cshtml
Outdated
Show resolved
Hide resolved
....GrantManager/src/Unity.GrantManager.Web/Pages/BulkApprovals/ApproveApplicationsModal.cshtml
Outdated
Show resolved
Hide resolved
plavoie-BC
changed the title
JamesPasta
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the bulk approval functionality where approval fields were missing during form submission. The fix ensures that RequestedAmount and RecommendedAmount values are properly preserved and transmitted when processing bulk application approvals.