AB#29664 update null electoral district address type handling #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndreGAot
commented
Aug 5, 2025
AndreGAot
commented
- Update the null form electoral district address type handling to make sure it defaults to Physical
- Add more logging when not processing for electoral district handling when it is already mapped
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses null electoral district address type handling by ensuring it defaults to Physical address type, while also improving logging for better debugging and monitoring.
- Enhanced null handling for electoral district address type with a default fallback to Physical address
- Improved logging throughout the electoral district determination process
- Fixed a spelling error in the code documentation
...ger/src/Unity.GrantManager.Application/Intakes/Handlers/DetermineElectoralDistrictHandler.cs
Show resolved
Hide resolved
...ger/src/Unity.GrantManager.Application/Intakes/Handlers/DetermineElectoralDistrictHandler.cs
Show resolved
Hide resolved
JamesPasta
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.