bugfix/AB#30978 and bugfix/AB#30979 - worksheet data grid #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements bugfixes for the custom DataGrid layout and action buttons, addressing issues AB#30978 and AB#30979. The changes modernize the DataGrid implementation to use DataTables 2.x layout configuration and API patterns.
Key changes:
- Migrated from legacy
domconfiguration to DataTables 2.xlayoutobject for better control over component positioning - Replaced custom search event binding with the
externalSearch()API for cleaner integration - Fixed HTML/CSS issues including a malformed class attribute and improved table styling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Default.cshtml | Fixed malformed class attribute (removed extra closing parenthesis) and added missing "table dataTable" classes |
| table-utils.js | Removed impractical page length option (1 record) from menu |
| layout.css | Added CSS rule to remove right border on last table header column for cleaner appearance |
| Default.js | Refactored to use DataTables 2.x layout API, added ColumnVisibility button, implemented externalSearch API, and simplified button configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ager/modules/Unity.Flex/src/Unity.Flex.Web/Views/Shared/Components/DataGridWidget/Default.js
Show resolved
Hide resolved
...ager/modules/Unity.Flex/src/Unity.Flex.Web/Views/Shared/Components/DataGridWidget/Default.js
Show resolved
Hide resolved
JamesPasta
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created bugfixes to fix custom DataGrid layout and action buttons after DataTables.net v2 upgrade.