AB#31186 queue form view gen to background task #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the form view generation process from a synchronous local event handler to an asynchronous background job, improving system responsiveness by offloading the database view generation to a background process.
Key changes:
- Converted
SubmissionsDynamicViewGeneratorHandlerfrom anILocalEventHandlerto anAsyncBackgroundJob - Renamed
SubmissionsDynamicViewGenerationEtotoSubmissionsDynamicViewGenerationArgsto reflect the change from event-driven to background job pattern - Updated
ReportingFieldsGeneratorServiceto useIBackgroundJobManager.EnqueueAsync()instead ofILocalEventBus.PublishAsync()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| SubmissionsDynamicViewGeneratorHandler.cs | Refactored from event handler to background job; changed base class to AsyncBackgroundJob<T>, renamed method from HandleEventAsync to ExecuteAsync, and extracted SQL execution into a separate method |
| SubmissionsDynamicViewGenerationArgs.cs | Renamed class from SubmissionsDynamicViewGenerationEto to SubmissionsDynamicViewGenerationArgs to align with background job naming conventions |
| ReportingFieldsGeneratorService.cs | Updated to use IBackgroundJobManager instead of ILocalEventBus, replaced PublishAsync with EnqueueAsync and added job priority and delay parameters |
| ApplicationFormVersionAppService.cs | Fixed typo in comment: changed "wit" to "with" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../Unity.GrantManager.Application/Reporting/FieldGenerators/ReportingFieldsGeneratorService.cs
Show resolved
Hide resolved
...nager/src/Unity.GrantManager.Application/Reporting/SubmissionsDynamicViewGeneratorHandler.cs
Show resolved
Hide resolved
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
Converted SubmissionsDynamicViewGeneratorHandler from an ILocalEventHandler to an AsyncBackgroundJob
Renamed SubmissionsDynamicViewGenerationEto to SubmissionsDynamicViewGenerationArgs to reflect the change from event-driven to background job pattern
Updated ReportingFieldsGeneratorService to use IBackgroundJobManager.EnqueueAsync() instead of ILocalEventBus.PublishAsync()