AB#27988: FSB-AP Payments Email Notification #1842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...les/Unity.Notifications/src/Unity.Notifications.Application/Emails/EmailAttachmentService.cs
Fixed
Show fixed
Hide fixed
...les/Unity.Notifications/src/Unity.Notifications.Application/Emails/EmailAttachmentService.cs
Fixed
Show fixed
Hide fixed
...ents/src/Unity.Payments.Application/PaymentRequests/Notifications/FsbApEmailGroupStrategy.cs
Fixed
Show fixed
Hide fixed
EmailConsumer gets the EmailLog while transaction of EmailLog creation form the publisher is not yet finished
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
...les/Unity.Notifications/src/Unity.Notifications.Application/Emails/EmailAttachmentService.cs
Fixed
Show fixed
Hide fixed
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will also fix the race condition in email sending where the EmailConsumer gets the EmailLog from the DB even though the transaction of the publisher that created the EmailLog is not yet finished