Skip to content

Conversation

@aurelio-aot
Copy link
Contributor

@aurelio-aot aurelio-aot commented Jan 19, 2026

hi @JamesPasta -- i noticed that ChesHttpStatusCode is not used yet anywhere in the code, let me know if you want me to delete this column instead. Thanks.

@github-actions
Copy link

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 289
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@JamesPasta
Copy link
Collaborator

Hey for your ticket Chse Rename can you add in the code here:

private async Task UpdateEmailLogStatus(EmailLog log, HttpResponseMessage response)
{
    log.ChesResponse = JsonConvert.SerializeObject(new
    {
        response.StatusCode,
        Headers = response.Headers?.ToString(),
        Body = response.Content != null ? response.Content.ReadAsStringAsync().Result : null
    });

log.ChesHttpStatusCode = response.StatusCode?.ToString("D") ?? string. Empty;

Idk I think

The ches response json has the status code in it anyway but maybe it is good to see the status code in a separate column

It tends to be faster to lookup

@JamesPasta JamesPasta merged commit 7d4588e into dev Jan 20, 2026
22 checks passed
@JamesPasta JamesPasta deleted the bugfix/AB#29266-ChseHttpStatusCode-typo-error branch January 20, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants