AB#31641 - remove dead code - UpdateProjectApplicantInfoAsync #1941
+69
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the obsolete UpdateProjectApplicantInfoAsync method and its related frontend code, as part of a dead code cleanup effort (AB#31641). The obsolete method was superseded by UpdatePartialApplicantInfoAsync in the ApplicationApplicantAppService class.
Changes:
- Removed obsolete C# backend method
UpdateProjectApplicantInfoAsyncfromGrantApplicationAppServiceand its interface definition - Removed unused JavaScript functions
checkUnityApplicantIdExistandupdateApplicantInfothat called the obsolete backend method - Cleaned up interface definition to remove the obsolete method signature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
GrantApplicationAppService.cs |
Removed the obsolete UpdateProjectApplicantInfoAsync method implementation (75 lines) |
IGrantApplicationAppService.cs |
Removed the obsolete method signature from the interface |
Default.js |
Removed two unused JavaScript functions that invoked the obsolete backend method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ntManager/src/Unity.GrantManager.Application/GrantApplications/GrantApplicationAppService.cs
Show resolved
Hide resolved
JamesPasta
deleted the
bugfix/AB#31641-deprecate-UpdateProjectApplicantInfoAsync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the obsolete UpdateProjectApplicantInfoAsync method and its related frontend code, as part of a dead code cleanup effort (AB#31641). The obsolete method was superseded by UpdatePartialApplicantInfoAsync in the ApplicationApplicantAppService class.